Issue 234663004: HashTable::Shrink() handlified and derived template parameter added to HashTable hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 234663004: HashTable::Shrink() handlified and derived template parameter added to HashTable hierarchy. (Closed)

Created:
6 years, 8 months ago by Igor Sheludko

Modified:
6 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

HashTable::Shrink() handlified and derived template parameter added to HashTable hierarchy. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20697

Patch Set 3 : Addressing review note #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+328 lines, -279 lines)			Patch
M	src/objects.h	View	1 2	17 chunks	+56 lines, -31 lines	0 comments	Download
M	src/objects.cc	View	1 2	30 chunks	+246 lines, -229 lines	0 comments	Download
M	src/objects-inl.h	View	1 2	5 chunks	+26 lines, -19 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with a comment that you can ignore if you want. https://codereview.chromium.org/234663004/diff/20001/src/objects.h File src/objects.h (right): ...

6 years, 8 months ago (2014-04-11 14:12:21 UTC) #3

Igor Sheludko

https://codereview.chromium.org/234663004/diff/20001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/234663004/diff/20001/src/objects.h#newcode3950 src/objects.h:3950: typedef HashTable<Derived, Shape, Key> HashTable_; On 2014/04/11 14:12:22, Yang ...

6 years, 8 months ago (2014-04-11 17:44:39 UTC) #4

Igor Sheludko

6 years, 8 months ago (2014-04-11 17:45:08 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r20697 (presubmit successful).

Expand Messages | Collapse Messages

Issue 234663004: HashTable::Shrink() handlified and derived template parameter added to HashTable hierarchy. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Some cleanup #

Patch Set 3 : Addressing review note #

Messages