network_list.js should reflect the correct logged in user type.

network_list.js should reflect the correct logged in user type.

Updated InternetOptionsHandler and network_list.js to observe LoginState
updates, so that using UIAccountTweaks is not the only way to determine
whether or not the current user is owner. This is because |loadTimeData|
may not contain the current user login details if the logged in user type
updates after the UI fills in the UIAccountTweaks info.

BUG=285589
R=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222390

[stevenjb, 2013-09-10 16:58:05]

lgtm

https://codereview.chromium.org/23466015/diff/1/chrome/browser/resources/opti...
File chrome/browser/resources/options/chromeos/network_list.js (right):

https://codereview.chromium.org/23466015/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/chromeos/network_list.js:477:
UIAccountTweaks.currentUserIsOwner());
Do we still need toe UIAccountTweaks check? If so, maybe add a local/comment to
explain what it is.

https://codereview.chromium.org/23466015/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/23466015/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1354: if
(web_ui()) {
nit: if (!web_ui()) return;

[armansito, 2013-09-10 21:55:19]

https://codereview.chromium.org/23466015/diff/1/chrome/browser/resources/opti...
File chrome/browser/resources/options/chromeos/network_list.js (right):

https://codereview.chromium.org/23466015/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/chromeos/network_list.js:477:
UIAccountTweaks.currentUserIsOwner());
On 2013/09/10 16:58:05, stevenjb wrote:
> Do we still need toe UIAccountTweaks check? If so, maybe add a local/comment
to
> explain what it is.

I originally thought that we should use UIAccountTweaks just in case
|loggedInUserType_| is not available. I think this shouldn't ever be the case so
we probably don't need the check.

https://codereview.chromium.org/23466015/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/23466015/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1354: if
(web_ui()) {
On 2013/09/10 16:58:05, stevenjb wrote:
> nit: if (!web_ui()) return;

Done.

[armansito, 2013-09-10 23:23:14]

Committed patchset #2 manually as r222390 (presubmit successful).