Wire up the output device id and provide an implementation on Windows.

Wire up the output device id and provide an implementation on Windows.
This adds the output device id to places where we already have an input device id.
On windows we now support a non-default device id in the WASAPI implementation.

BUG=276894
R=henrika@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221684

[tommi (sloooow) - chröme, 2013-09-05 15:58:23]

https://codereview.chromium.org/23466008/diff/1/media/audio/audio_output_resa...
File media/audio/audio_output_resampler.h (left):

https://codereview.chromium.org/23466008/diff/1/media/audio/audio_output_resa...
media/audio/audio_output_resampler.h:78: const std::string input_device_id_;
fyi - this variable isn't needed so I'm removing it.

A variable with the same name and purpose exists already in the parent class
(and is initialized to the same value), so we're now just using it instead.

[tommi (sloooow) - chröme, 2013-09-05 16:29:33]

Add AudioOutputController

[tommi (sloooow) - chröme, 2013-09-06 08:03:27]

Switch argument order in AudioOutputController for consistency

[henrika (OOO until Aug 14), 2013-09-06 08:44:38]

LGTM.

https://codereview.chromium.org/23466008/diff/34001/media/audio/audio_output_...
File media/audio/audio_output_controller.h (right):

https://codereview.chromium.org/23466008/diff/34001/media/audio/audio_output_...
media/audio/audio_output_controller.h:103: // outlive AudioOutputController.
Should we extend the comment and mention device IDs as well?

https://codereview.chromium.org/23466008/diff/34001/media/audio/audio_output_...
media/audio/audio_output_controller.h:202: // Specified the device id of the
output device to open or empty for the
Specified the device id of... sounds odd to me. Did you mean Specifies...

[tommi (sloooow) - chröme, 2013-09-06 11:00:34]

Update comments

[tommi (sloooow) - chröme, 2013-09-06 11:01:35]

https://codereview.chromium.org/23466008/diff/34001/media/audio/audio_output_...
File media/audio/audio_output_controller.h (right):

https://codereview.chromium.org/23466008/diff/34001/media/audio/audio_output_...
media/audio/audio_output_controller.h:103: // outlive AudioOutputController.
On 2013/09/06 08:44:38, henrika wrote:
> Should we extend the comment and mention device IDs as well?

Done.

https://codereview.chromium.org/23466008/diff/34001/media/audio/audio_output_...
media/audio/audio_output_controller.h:202: // Specified the device id of the
output device to open or empty for the
On 2013/09/06 08:44:38, henrika wrote:
> Specified the device id of... sounds odd to me. Did you mean Specifies...

Yes, thanks, fixed.

[henrika (OOO until Aug 14), 2013-09-06 11:04:00]

LGTM++


On Fri, Sep 6, 2013 at 1:01 PM, <tommi@chromium.org> wrote:

>
> https://codereview.chromium.**org/23466008/diff/34001/media/**
>
audio/audio_output_controller.**h<https://codereview.chromium.org/23466008/diff/34001/media/audio/audio_output_controller.h>
> File media/audio/audio_output_**controller.h (right):
>
> https://codereview.chromium.**org/23466008/diff/34001/media/**
>
audio/audio_output_controller.**h#newcode103<https://codereview.chromium.org/23466008/diff/34001/media/audio/audio_output_controller.h#newcode103>
> media/audio/audio_output_**controller.h:103: // outlive
> AudioOutputController.
> On 2013/09/06 08:44:38, henrika wrote:
>
>> Should we extend the comment and mention device IDs as well?
>>
>
> Done.
>
>
> https://codereview.chromium.**org/23466008/diff/34001/media/**
>
audio/audio_output_controller.**h#newcode202<https://codereview.chromium.org/23466008/diff/34001/media/audio/audio_output_controller.h#newcode202>
> media/audio/audio_output_**controller.h:202: // Specified the device id of
> the output device to open or empty for the
> On 2013/09/06 08:44:38, henrika wrote:
>
>> Specified the device id of... sounds odd to me. Did you mean
>>
> Specifies...
>
> Yes, thanks, fixed.
>
>
https://codereview.chromium.**org/23466008/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tommi (sloooow) - chröme, 2013-09-06 11:48:33]

Committed patchset #4 manually as r221684 (presubmit successful).