Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2346593002: Revert of Enforce capability spec renderer <--> browser (Closed)

Created:
4 years, 3 months ago by oystein (OOO til 10th of July)
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enforce capability spec renderer <--> browser (patchset #14 id:260001 of https://codereview.chromium.org/2259903002/ ) Reason for revert: Introduces crashes in Mojo on all Windows perf bots: https://bugs.chromium.org/p/chromium/issues/detail?id=647006 Original issue's description: > Enforce capability spec renderer <--> browser. > > This implements: > > - allows the content embedder to merge a manifest into the base ones provided by content, allowing it to add to the list of interfaces exposed to the renderer. > - adds such an overlay to chrome/browser > > So.. from now on if you add an interface to either the browser/renderer, you'll need to list it in the manifest. I wonder how we should broadcast this. Also as a separate step we should require these manifests get security review. > > R=rockot@chromium.org,tsepez@chromium.org > > Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3 > Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba > Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a > Cr-Original-Original-Commit-Position: refs/heads/master@{#418282} > Cr-Original-Commit-Position: refs/heads/master@{#418398} > Cr-Commit-Position: refs/heads/master@{#418582} TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -364 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 4 chunks +0 lines, -18 lines 0 comments Download
D chrome/browser/content_browser_manifest_overlay.json View 1 chunk +0 lines, -15 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/browser_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 2 chunks +1 line, -1 line 0 comments Download
D content/browser/mojo/merge_dictionary.h View 1 chunk +0 lines, -21 lines 0 comments Download
D content/browser/mojo/merge_dictionary.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D content/browser/mojo/merge_dictionary_unittest.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 4 chunks +9 lines, -57 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/utility_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/child/child_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A content/common/mojo/constants.h View 1 chunk +20 lines, -0 lines 0 comments Download
A content/common/mojo/constants.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/public/app/mojo/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 2 chunks +2 lines, -20 lines 0 comments Download
M content/public/app/mojo/content_renderer_manifest.json View 1 chunk +2 lines, -10 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/public/common/service_names.h View 1 chunk +0 lines, -20 lines 0 comments Download
D content/public/common/service_names.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/catalog/manifest_provider.h View 2 chunks +3 lines, -4 lines 0 comments Download
M services/catalog/reader.cc View 1 chunk +18 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
oystein (OOO til 10th of July)
Created Revert of Enforce capability spec renderer <--> browser
4 years, 3 months ago (2016-09-14 20:36:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346593002/1
4 years, 3 months ago (2016-09-14 20:37:23 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/browser_resources.grd: While running git apply --index -3 -p1; error: patch ...
4 years, 3 months ago (2016-09-14 20:38:49 UTC) #5
oystein (OOO til 10th of July)
4 years, 3 months ago (2016-09-14 20:42:20 UTC) #8
Message was sent while issue was closed.
(Closed; already reverted)

Powered by Google App Engine
This is Rietveld 408576698