Issue 2346573002: Fix build break.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2346573002: Fix build break. (Closed)

Created:
4 years, 3 months ago by Jacob

Modified:
4 years, 3 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix build break. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/d858c4f2ae348fedae2340b3c6d80e5f246371bd

Patch Set 1 #

Total comments: 1

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	pkg/dev_compiler/test/codegen_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	pkg/dev_compiler/web/web_command.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/2346573002/diff/1/pkg/dev_compiler/web/web_command.dart File pkg/dev_compiler/web/web_command.dart (right): https://codereview.chromium.org/2346573002/diff/1/pkg/dev_compiler/web/web_command.dart#newcode132 pkg/dev_compiler/web/web_command.dart:132: .getCode(ModuleFormat.legacy, false, unit.name, unit.name + '.map') long line, ...

4 years, 3 months ago (2016-09-14 20:07:03 UTC) #3

Jacob

4 years, 3 months ago (2016-09-14 20:07:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d858c4f2ae348fedae2340b3c6d80e5f246371bd (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages