Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 2346553002: Disable ignore discard optimization in Vulkan (Closed)

Created:
4 years, 3 months ago by egdaniel
Modified:
4 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable ignore discard optimization in Vulkan BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346553002 Committed: https://skia.googlesource.com/skia/+/f6a97aec198ba4b456a625e37254457bb981940a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/gpu/vk/GrVkGpuCommandBuffer.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
egdaniel
4 years, 3 months ago (2016-09-14 17:56:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346553002/1
4 years, 3 months ago (2016-09-14 17:56:39 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-14 17:56:41 UTC) #6
robertphillips
lgtm
4 years, 3 months ago (2016-09-14 17:59:14 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 18:26:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f6a97aec198ba4b456a625e37254457bb981940a

Powered by Google App Engine
This is Rietveld 408576698