Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2346543002: kernel -> ssa: implement literal lists (Closed)

Created:
4 years, 3 months ago by Harry Terkelsen
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org, dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -4 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 1 chunk +21 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/kernel/literals_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
4 years, 3 months ago (2016-09-14 17:34:01 UTC) #2
Siggi Cherem (dart-lang)
lgtm, nice https://codereview.chromium.org/2346543002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2346543002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode285 pkg/compiler/lib/src/ssa/builder_kernel.dart:285: listInstruction = graph.addConstant(astAdapter.getConstantFor(listLiteral), compiler); dartfmt
4 years, 3 months ago (2016-09-14 18:23:27 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/2346543002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2346543002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode285 pkg/compiler/lib/src/ssa/builder_kernel.dart:285: listInstruction = graph.addConstant(astAdapter.getConstantFor(listLiteral), compiler); On 2016/09/14 18:23:26, Siggi Cherem ...
4 years, 3 months ago (2016-09-14 18:25:56 UTC) #4
Harry Terkelsen
4 years, 3 months ago (2016-09-14 18:26:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
866e4ea5509913a06c5234b12498d8f30714cce6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698