Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 234653002: Xfermode: SSE2 implementation of darken&lighten mode (Closed)

Created:
6 years, 8 months ago by qiankun
Modified:
6 years, 7 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Xfermode: SSE2 implementation of darken&lighten mode With SSE2 optimization, performance of the related two benchmarks will improve about 45% on desktop i7-3770. Here are the data: before: Xfermode_Lighten 8888: cmsecs = 33.60 565: cmsecs = 48.84 Xfermode_Darken 8888: cmsecs = 34.16 565: cmsecs = 48.99 after: Xfermode_Lighten 8888: cmsecs = 18.71 565: cmsecs = 25.41 Xfermode_Darken 8888: cmsecs = 18.39 565: cmsecs = 25.40 BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14395

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase and fix reviewer's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -2 lines) Patch
M src/opts/SkXfermode_opts_SSE2.cpp View 1 2 chunks +60 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
qiankun
PTAL.
6 years, 8 months ago (2014-04-11 05:39:58 UTC) #1
mtklein
https://codereview.chromium.org/234653002/diff/1/src/opts/SkXfermode_opts_SSE2.cpp File src/opts/SkXfermode_opts_SSE2.cpp (right): https://codereview.chromium.org/234653002/diff/1/src/opts/SkXfermode_opts_SSE2.cpp#newcode94 src/opts/SkXfermode_opts_SSE2.cpp:94: __m128i ret1 = _mm_add_epi32(sc, dc); I'm not sure why ...
6 years, 8 months ago (2014-04-24 17:55:11 UTC) #2
qiankun
updated the CL, PTAL. https://codereview.chromium.org/234653002/diff/1/src/opts/SkXfermode_opts_SSE2.cpp File src/opts/SkXfermode_opts_SSE2.cpp (right): https://codereview.chromium.org/234653002/diff/1/src/opts/SkXfermode_opts_SSE2.cpp#newcode94 src/opts/SkXfermode_opts_SSE2.cpp:94: __m128i ret1 = _mm_add_epi32(sc, dc); ...
6 years, 8 months ago (2014-04-25 14:13:24 UTC) #3
mtklein
lgtm
6 years, 8 months ago (2014-04-25 14:33:59 UTC) #4
qiankun
The CQ bit was checked by qiankun.miao@intel.com
6 years, 8 months ago (2014-04-26 05:04:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/qiankun.miao@intel.com/234653002/20001
6 years, 8 months ago (2014-04-26 05:04:41 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 13:26:55 UTC) #7
Message was sent while issue was closed.
Change committed as 14395

Powered by Google App Engine
This is Rietveld 408576698