cocoa browser: don't make non-MD tab titles smaller

cocoa browser: don't make non-MD tab titles smaller

Setting the title frame to be 14px high clips descenders from the text.
If TabController leaves the title frame at its default size, the text
draws properly and is vertically centered in the tab.

BUG=645755
Committed: https://crrev.com/235ec06ba2318c7656bf40efdfa385cf68b2b92d
Cr-Commit-Position: refs/heads/master@{#419465}

[Elly Fong-Jones, 2016-09-16 16:43:49]

Description was changed from

==========
cocoa browser: don't make non-MD tab titles smaller

Setting the title frame to be 14px high clips descenders from the text.
If TabController leaves the title frame at its default size, the text
draws properly and is vertically centered in the tab.

BUG=645755
==========

to

==========
cocoa browser: don't make non-MD tab titles smaller

Setting the title frame to be 14px high clips descenders from the text.
If TabController leaves the title frame at its default size, the text
draws properly and is vertically centered in the tab.

BUG=645755
==========

[Elly Fong-Jones, 2016-09-16 16:43:49]

ellyjones@chromium.org changed reviewers:
+ shrike@chromium.org

[Elly Fong-Jones, 2016-09-16 16:43:56]

shrike: ptal? :)

[shrike, 2016-09-16 18:51:09]

lgtm

https://codereview.chromium.org/2346513006/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_controller.mm (left):

https://codereview.chromium.org/2346513006/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_controller.mm:111: titleFrame.size.height = 14;
Pre-MD this code read

    NSRect titleFrame = NSMakeRect(35, 6, 92, 14);

so this statement was just preserving the original height. I'm not sure why that
no longer works.

[Elly Fong-Jones, 2016-09-19 10:14:47]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-09-19 10:14:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 10:22:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 10:22:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Elly Fong-Jones, 2016-09-19 10:24:09]

ellyjones@chromium.org changed reviewers:
+ avi@chromium.org

[Elly Fong-Jones, 2016-09-19 10:24:20]

avi: ptal? :)

[Avi (use Gerrit), 2016-09-19 13:55:22]

lgtm

stampity stamp

[Elly Fong-Jones, 2016-09-19 15:26:17]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-09-19 15:26:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 15:31:18]

Description was changed from

==========
cocoa browser: don't make non-MD tab titles smaller

Setting the title frame to be 14px high clips descenders from the text.
If TabController leaves the title frame at its default size, the text
draws properly and is vertically centered in the tab.

BUG=645755
==========

to

==========
cocoa browser: don't make non-MD tab titles smaller

Setting the title frame to be 14px high clips descenders from the text.
If TabController leaves the title frame at its default size, the text
draws properly and is vertically centered in the tab.

BUG=645755
==========

[commit-bot: I haz the power, 2016-09-19 15:31:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-19 15:32:31]

Description was changed from

==========
cocoa browser: don't make non-MD tab titles smaller

Setting the title frame to be 14px high clips descenders from the text.
If TabController leaves the title frame at its default size, the text
draws properly and is vertically centered in the tab.

BUG=645755
==========

to

==========
cocoa browser: don't make non-MD tab titles smaller

Setting the title frame to be 14px high clips descenders from the text.
If TabController leaves the title frame at its default size, the text
draws properly and is vertically centered in the tab.

BUG=645755

Committed: https://crrev.com/235ec06ba2318c7656bf40efdfa385cf68b2b92d
Cr-Commit-Position: refs/heads/master@{#419465}
==========

[commit-bot: I haz the power, 2016-09-19 15:32:32]

Patchset 1 (id:??) landed as
https://crrev.com/235ec06ba2318c7656bf40efdfa385cf68b2b92d
Cr-Commit-Position: refs/heads/master@{#419465}