Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: trunk/Source/core/css/CSSParser-in.cpp

Issue 23465021: Revert 157745 "Add support for the object-position CSS property." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/Source/core/css/CSSParser.h ('k') | trunk/Source/core/css/CSSProperties.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/core/css/CSSParser-in.cpp
===================================================================
--- trunk/Source/core/css/CSSParser-in.cpp (revision 157750)
+++ trunk/Source/core/css/CSSParser-in.cpp (working copy)
@@ -145,9 +145,9 @@
return false;
}
-static PassRefPtr<CSSPrimitiveValue> createPrimitiveValuePair(PassRefPtr<CSSPrimitiveValue> first, PassRefPtr<CSSPrimitiveValue> second, Pair::IdenticalValuesPolicy identicalValuesPolicy = Pair::DropIdenticalValues)
+static PassRefPtr<CSSPrimitiveValue> createPrimitiveValuePair(PassRefPtr<CSSPrimitiveValue> first, PassRefPtr<CSSPrimitiveValue> second)
{
- return cssValuePool().createValue(Pair::create(first, second, identicalValuesPolicy));
+ return cssValuePool().createValue(Pair::create(first, second));
}
class AnimationParseContext {
@@ -1990,8 +1990,6 @@
m_implicitShorthand = false;
return result;
}
- case CSSPropertyObjectPosition:
- return RuntimeEnabledFeatures::objectFitPositionEnabled() && parseObjectPosition(important);
case CSSPropertyListStyleImage: // <uri> | none | inherit
case CSSPropertyBorderImageSource:
case CSSPropertyWebkitMaskBoxImageSource:
@@ -6618,20 +6616,6 @@
return true;
}
-bool CSSParser::parseObjectPosition(bool important)
-{
- RefPtr<CSSValue> xValue;
- RefPtr<CSSValue> yValue;
- parseFillPosition(m_valueList.get(), xValue, yValue);
- if (!xValue || !yValue)
- return false;
- addProperty(
- CSSPropertyObjectPosition,
- createPrimitiveValuePair(toCSSPrimitiveValue(xValue.get()), toCSSPrimitiveValue(yValue.get()), Pair::KeepIdenticalValues),
- important);
- return true;
-}
-
struct BorderImageParseContext {
BorderImageParseContext()
: m_canAdvance(false)
« no previous file with comments | « trunk/Source/core/css/CSSParser.h ('k') | trunk/Source/core/css/CSSProperties.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698