Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 23465012: First round of GPU gradient rebaseline (Closed)

Created:
7 years, 3 months ago by bsalomon
Modified:
7 years, 3 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

First round of GPU gradient rebaseline Committed: https://code.google.com/p/skia/source/detail?r=11161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -116 lines) Patch
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 44 chunks +44 lines, -44 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 26 chunks +26 lines, -26 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 24 chunks +24 lines, -24 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 22 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
Committed patchset #1 manually as r11161 (presubmit successful).
7 years, 3 months ago (2013-09-09 16:26:59 UTC) #1
epoger
LGTM Just out of curiosity, why the "rounds" of rebaselining? Is there something in the ...
7 years, 3 months ago (2013-09-09 16:28:18 UTC) #2
bsalomon
On 2013/09/09 16:28:18, epoger wrote: > LGTM > > Just out of curiosity, why the ...
7 years, 3 months ago (2013-09-09 16:31:55 UTC) #3
epoger
On 2013/09/09 16:31:55, bsalomon wrote: > On 2013/09/09 16:28:18, epoger wrote: > > LGTM > ...
7 years, 3 months ago (2013-09-09 16:32:41 UTC) #4
bsalomon
7 years, 3 months ago (2013-09-09 16:36:01 UTC) #5
Message was sent while issue was closed.
On 2013/09/09 16:31:55, bsalomon wrote:
> On 2013/09/09 16:28:18, epoger wrote:
> > LGTM
> > 
> > Just out of curiosity, why the "rounds" of rebaselining?  Is there something
> in
> > the process that can only support a certain number of tests at a time?
> 
> I wanted to get images checked in for the bots that have already finished. If
> they turn green then it'll make me feel better that I haven't broken anything
> even though there's a longer tail of bots to finish taking care of. Also, if
> most of the bots go green before all are finished I'd take the tree off of
> yellow to unblock the commit queue.

One other thing: this change touches a lot of tests, so the rebaseline is a bit
harder than normal. I don't want to get confused by any other unrelated
lingering image mismatches or flakes. So I picked a bot that was green and went
red on my change. I grabbed it's set of image mismatches and used that with the
--tests param to try to isolate my rebaselining. I'm not 100% sure that the set
is complete. So if I get an early round in I can see if it is the correct set
for some other bots and update it if not.

Powered by Google App Engine
This is Rietveld 408576698