Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 23465004: More cleanup related to malformed and malbounded types. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/parser.cc ('K') | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object_snapshot.cc
===================================================================
--- runtime/vm/raw_object_snapshot.cc (revision 26669)
+++ runtime/vm/raw_object_snapshot.cc (working copy)
@@ -11,7 +11,7 @@
namespace dart {
-DECLARE_FLAG(bool, error_on_malformed_type);
+DECLARE_FLAG(bool, error_on_bad_type);
#define NEW_OBJECT(type) \
@@ -247,7 +247,7 @@
// Only resolved and finalized types should be written to a snapshot.
// TODO(regis): Replace the test below by an ASSERT() or remove the flag test.
- if (FLAG_error_on_malformed_type &&
+ if (FLAG_error_on_bad_type &&
(ptr()->type_state_ != RawType::kFinalizedInstantiated) &&
(ptr()->type_state_ != RawType::kFinalizedUninstantiated)) {
// Print the name of the class of the unfinalized type, as well as the
@@ -335,7 +335,7 @@
// Only finalized type parameters should be written to a snapshot.
// TODO(regis): Replace the test below by an ASSERT() or remove the flag test.
- if (FLAG_error_on_malformed_type &&
+ if (FLAG_error_on_bad_type &&
(ptr()->type_state_ != RawTypeParameter::kFinalizedUninstantiated)) {
// Print the name of the unfinalized type parameter, the name of the class
// it parameterizes, as well as the token location from where it is referred
« runtime/vm/parser.cc ('K') | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698