tools/perf/page_sets/gmail_expand_collapse_conversation.json - Issue 23465003: Adding pagesets for gmail and plus. Creating endure benchmark

Side by Side Diff: tools/perf/page_sets/gmail_expand_collapse_conversation.json

Issue 23465003: Adding pagesets for gmail and plus. Creating endure benchmark (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« tools/perf/page_sets/gmail_alt_two_labels.json ('K') | « tools/perf/page_sets/gmail_alt_two_labels.json ('k') | tools/perf/page_sets/plus_alt_posts_photos.json » ('j') | tools/perf/page_sets/plus_alt_posts_photos.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "description": "Chrome Endure test for GMail.",

	3 "archive_data_file": "../data/gmail_expand_collapse_conversation.json",

	4 "credentials_path": "../data/credentials.json",

	5 "user_agent_type": "desktop",

	6 "pages": [

	7 {

	8 "url": "https://mail.google.com/mail/u/0/#inbox/13c6a141fa95ffe0",
	edmundyan 2013/08/26 21:31:55 How do we ensure we enter a long conversation mail How do we ensure we enter a long conversation mail? dennis_jeffrey 2013/08/27 20:02:35 Right now we have to ensure the account is set up Show quoted text On 2013/08/26 21:31:55, edmundyan wrote: > How do we ensure we enter a long conversation mail? Right now we have to ensure the account is set up in such a way that a long conversation e-mails opens up (and the e-mails in the account don't change from run to run). WebPageReplay can help when we're replaying things, but in recording mode, we still have to ensure a long conversation e-mail is used. In the future we should think about how to better ensure this. edmundyan 2013/08/27 23:01:48 So is the explicit URL acceptable? This won't wor Show quoted text On 2013/08/27 20:02:35, dennis_jeffrey wrote: > On 2013/08/26 21:31:55, edmundyan wrote: > > How do we ensure we enter a long conversation mail? > > Right now we have to ensure the account is set up in such a way that a long > conversation e-mails opens up (and the e-mails in the account don't change from > run to run). WebPageReplay can help when we're replaying things, but in > recording mode, we still have to ensure a long conversation e-mail is used. In > the future we should think about how to better ensure this. So is the explicit URL acceptable? This won't work for other accounts. The old chrome endure test just clicked the 1st email in the inbox and hoped it would have replies. dennis_jeffrey 2013/08/27 23:17:22 I'd say it's acceptable with a TODO added to the c Show quoted text On 2013/08/27 23:01:48, edmundyan wrote: > On 2013/08/27 20:02:35, dennis_jeffrey wrote: > > On 2013/08/26 21:31:55, edmundyan wrote: > > > How do we ensure we enter a long conversation mail? > > > > Right now we have to ensure the account is set up in such a way that a long > > conversation e-mails opens up (and the e-mails in the account don't change > from > > run to run). WebPageReplay can help when we're replaying things, but in > > recording mode, we still have to ensure a long conversation e-mail is used. > In > > the future we should think about how to better ensure this. > > So is the explicit URL acceptable? This won't work for other accounts. The old > chrome endure test just clicked the 1st email in the inbox and hoped it would > have replies. I'd say it's acceptable with a TODO added to the code that we should implement a better approach.
	9 "why": "Expand and Collapse a long conversation",

	10 "credentials": "google",

	11 "navigate_steps": [

	12 { "action": "navigate" },

	13 { "action": "endure" },

	14 { "action": "wait", "condition": "duration", "seconds": 10 }
	edmundyan 2013/08/26 21:31:55 Need to ensure that all expanded emails have their Need to ensure that all expanded emails have their contents downloaded (this is more for WPR to correctly record). There should be a more precise way to know when all downloading is complete.
	15 ],

	16 "endure": [

	17 { "action": "wait", "condition": "element", "selector": "img[alt=\"Expan d all\"]" },

	18 { "action": "click_element", "selector": "img[alt=\"Expand all\"]" },

	19 { "action": "wait", "condition": "duration", "seconds": 1 },

	20 { "action": "wait", "condition": "element", "selector": "img[alt=\"Colla pse all\"]" },

	21 { "action": "click_element", "selector": "img[alt=\"Collapse all\"]" },

	22 { "action": "wait", "condition": "duration", "seconds": 1 }

	23 ]

	24 }

	25 ]

	26 }

OLD	NEW