tools/perf/page_sets/gmail_alt_threadlist_conversation.json - Issue 23465003: Adding pagesets for gmail and plus. Creating endure benchmark

Side by Side Diff: tools/perf/page_sets/gmail_alt_threadlist_conversation.json

Issue 23465003: Adding pagesets for gmail and plus. Creating endure benchmark (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 {

	2 "description": "Chrome Endure test for GMail.",
	dennis_jeffrey 2013/08/27 20:02:35 is there a length limit on the description? Maybe is there a length limit on the description? Maybe we should add a phrase here to indicate what scenario is performed, e.g., "Gmail endurance test that alternates between the threadlist and conversation views." If you make this change, do the same for the other JSON files in this CL edmundyan 2013/08/27 23:01:48 I've been putting more detailed descriptions in th Show quoted text On 2013/08/27 20:02:35, dennis_jeffrey wrote: > is there a length limit on the description? Maybe we should add a phrase here > to indicate what scenario is performed, e.g., "Gmail endurance test that > alternates between the threadlist and conversation views." > > If you make this change, do the same for the other JSON files in this CL I've been putting more detailed descriptions in the "why" for the page (below). Should I move that up to description instead? dennis_jeffrey 2013/08/27 23:17:22 Oh, didn't realize that. Maybe it's ok as is. Cu Show quoted text On 2013/08/27 23:01:48, edmundyan wrote: > On 2013/08/27 20:02:35, dennis_jeffrey wrote: > > is there a length limit on the description? Maybe we should add a phrase here > > to indicate what scenario is performed, e.g., "Gmail endurance test that > > alternates between the threadlist and conversation views." > > > > If you make this change, do the same for the other JSON files in this CL > > I've been putting more detailed descriptions in the "why" for the page (below). > Should I move that up to description instead? Oh, didn't realize that. Maybe it's ok as is. Currently, we need a separate pageset file for each endure scenario, but in the future if that's no longer the case, then the pageset "description" should probably be something more general anyway.
	3 "archive_data_file": "../data/gmail_alt_threadlist_conversation.json",

	4 "credentials_path": "../data/credentials.json",

	5 "user_agent_type": "desktop",

	6 "pages": [

	7 {

	8 "url": "https://mail.google.com/mail/",

	9 "why": "Alternate between Inbox and the first email conversation",

	10 "credentials": "google",

	11 "navigate_steps" : [

	12 { "action": "navigate" },

	13 { "action": "wait", "condition": "javascript", "javascript": "window.gmo nkey !== undefined && document.getElementById('gb') !== null"}
	dennis_jeffrey 2013/08/27 20:02:35 add space before the closing } to keep style consi add space before the closing } to keep style consistent in this file edmundyan 2013/08/27 23:01:48 Done. Show quoted text On 2013/08/27 20:02:35, dennis_jeffrey wrote: > add space before the closing } to keep style consistent in this file Done.
	14 ],

	15 "endure": [

	16 {

	17 "action": "click_element",

	18 "xpath": "//span[@email]"

	19 },

	20 { "action": "wait", "condition": "href_change" },

	21 { "action": "wait", "condition": "duration", "seconds": 1 },
	tonyg 2013/08/27 01:23:02 I thought we got rid of condition: duration I thought we got rid of condition: duration
	22 {

	23 "action": "click_element",

	24 "selector": "a[href=\"https://mail.google.com/mail/u/0/?shva=1#inbox\" ]"

	25 },

	26 { "action": "wait", "condition": "href_change"},
	dennis_jeffrey 2013/08/27 20:02:35 add space before the closing } to keep style consi add space before the closing } to keep style consistent in this file
	27 { "action": "wait", "condition": "duration", "seconds": 1 }

	28 ]

	29 }

	30 ]

	31 }

OLD	NEW

« tools/perf/benchmarks/endure.py ('K') | « tools/perf/benchmarks/endure.py ('k') | tools/perf/page_sets/gmail_alt_two_labels.json » ('j') | tools/perf/page_sets/gmail_alt_two_labels.json » ('J')