Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 2346483007: Update observatory_tool.py to remove package-root (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M runtime/observatory/observatory.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M tools/bots/bot.py View 2 chunks +1 line, -4 lines 0 comments Download
M tools/observatory_tool.py View 6 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Bill Hesse
I think this is the best way to solve this - I don't see any ...
4 years, 3 months ago (2016-09-16 14:36:52 UTC) #2
Cutch
LGTM but does this mean that we are using the same .packages as the sdk ...
4 years, 3 months ago (2016-09-16 14:41:27 UTC) #3
Bill Hesse
On 2016/09/16 14:41:27, Cutch wrote: > LGTM but does this mean that we are using ...
4 years, 3 months ago (2016-09-19 08:09:28 UTC) #4
Bill Hesse
4 years, 3 months ago (2016-09-19 08:11:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9f3b5d8680f1b264d6c9300b3759383cdd6561d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698