Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2346483006: Create a subset of skia support for paths only (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com, Tom Sepez, Wei Li
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Create a subset of skia support for paths only This removes the need for agg, without providing full Skia support. It doesn't work yet, but it does compile and run for simple PDFs. R=dsinclair@google.com

Patch Set 1 #

Patch Set 2 : use skia only for paths #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -12 lines) Patch
M BUILD.gn View 3 chunks +6 lines, -2 lines 0 comments Download
M README.md View 1 chunk +1 line, -0 lines 0 comments Download
M build_overrides/pdfium.gni View 1 chunk +4 lines, -1 line 0 comments Download
M core/fxge/apple/fx_quartz_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.h View 1 5 chunks +11 lines, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 30 chunks +188 lines, -3 lines 2 comments Download
M pdfium.gni View 1 chunk +4 lines, -1 line 0 comments Download
M samples/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (8 generated)
dsinclair
4 years, 3 months ago (2016-09-19 20:45:12 UTC) #8
Cool, so the USE_PATHs variant is using enough of Skia that we can remove AGG?
Is the performance similar between the two?

This seems like a really good half way point to getting us to Skia. We can
remove AGG and start incrementally making our Skia backend better without the
baggage of maintaining the old code paths.

https://codereview.chromium.org/2346483006/diff/20001/core/fxge/skia/fx_skia_...
File core/fxge/skia/fx_skia_device.cpp (right):

https://codereview.chromium.org/2346483006/diff/20001/core/fxge/skia/fx_skia_...
core/fxge/skia/fx_skia_device.cpp:22: #ifdef _SKIA_SUPPORT_
Let's consolidate all of these header if's into fewer blocks if possible.

https://codereview.chromium.org/2346483006/diff/20001/core/fxge/skia/fx_skia_...
core/fxge/skia/fx_skia_device.cpp:1662: return
((CFX_ImageRenderer*)pHandle)->Continue(pPause);
nit: static_cast.

Powered by Google App Engine
This is Rietveld 408576698