Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 23464103: Rename/modify test case for explicitly set caret type (Closed)

Created:
7 years, 3 months ago by vanihegde
Modified:
7 years, 3 months ago
Reviewers:
tkent, yosin_UTC9, ojan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename/modify test case for explicitly set caret type This test has nothing to do with user-select: none. Hence renaming the test case. This test was created as part of https://codereview.chromium.org/23461040/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -48 lines) Patch
LayoutTests/editing/caret/caret-type-for-user-select-none.html View 1 chunk +0 lines, -37 lines 0 comments Download
LayoutTests/editing/caret/caret-type-for-user-select-none-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
A + LayoutTests/editing/caret/selection-with-caret-type-progress.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/editing/caret/selection-with-caret-type-progress-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vanihegde
I had wrongly named the test case initially as per the bug description http://code.google.com/p/chromium/issues/detail?id=134999 During ...
7 years, 3 months ago (2013-09-20 05:07:46 UTC) #1
yosin_UTC9
ACK +tkent@ for same time zone reviewer.
7 years, 3 months ago (2013-09-20 05:19:57 UTC) #2
ojan
lgtm
7 years, 3 months ago (2013-09-20 05:22:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/23464103/1
7 years, 3 months ago (2013-09-20 05:22:36 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 06:45:51 UTC) #5
Message was sent while issue was closed.
Change committed as 158085

Powered by Google App Engine
This is Rietveld 408576698