android_webview/native/aw_contents.cc - Issue 23464080: [Android] Decouple pausing video from RenderView pause.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.cc

Issue 23464080: [Android] Decouple pausing video from RenderView pause. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/native/aw_contents.cc

diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc

index 2db91fa2c4d2dde0621e74685a6d9c2d2886341b..e527f5a39759cb20e80ee1f29550688cc3194dce 100644

--- a/android_webview/native/aw_contents.cc

+++ b/android_webview/native/aw_contents.cc

@@ -686,6 +686,7 @@ void AwContents::SetWindowVisibility(JNIEnv* env, jobject obj, bool visible) {

void AwContents::SetIsPaused(JNIEnv* env, jobject obj, bool paused) {

browser_view_renderer_->SetIsPaused(paused);

+ ContentViewCore::FromWebContents(web_contents_.get())->PauseVideo();

boliu 2013/09/19 01:58:39 condition on if (paused)

joth 2013/09/19 02:41:50 null check it.

benm (inactive) 2013/09/19 03:27:32 Done both, thanks!

}

void AwContents::OnAttachedToWindow(JNIEnv* env, jobject obj, int w, int h) {

« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.h » ('j') | content/browser/android/content_view_core_impl.cc » ('J')