content/renderer/media/android/renderer_media_player_manager.h - Issue 23464080: [Android] Decouple pausing video from RenderView pause.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/renderer_media_player_manager.h

Issue 23464080: [Android] Decouple pausing video from RenderView pause. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/browser/android/content_view_core.h ('k') | content/renderer/media/android/renderer_media_player_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/android/renderer_media_player_manager.h

diff --git a/content/renderer/media/android/renderer_media_player_manager.h b/content/renderer/media/android/renderer_media_player_manager.h

index 3e5e13c343308d66b8be1aeb3a37b63d6d0fd330..e565602a279ed92f461262cf970b77d35748f034 100644

--- a/content/renderer/media/android/renderer_media_player_manager.h

+++ b/content/renderer/media/android/renderer_media_player_manager.h

@@ -32,9 +32,9 @@ class RendererMediaPlayerManager {

int RegisterMediaPlayer(WebMediaPlayerAndroid* player);

void UnregisterMediaPlayer(int player_id);

- // Release all the media resources managed by this object unless

- // an audio play is in progress.

- void ReleaseMediaResources();

+ // Release the media resources managed by this object when a video

+ // is playing.

+ void ReleaseVideoResources();

// Check whether a player can enter fullscreen.

bool CanEnterFullscreen(WebKit::WebFrame* frame);