Make Dart_IdentityEqual live up to its spec and not leak boxing implementation detail.

runtime/lib/identical.cc

Index: runtime/lib/identical.cc
diff --git a/runtime/lib/identical.cc b/runtime/lib/identical.cc
index 7508f03ac85b89431dcdab9ae78ea8384becb4b5..efbb4911a2e6c5a047e23aa7b74884bdd0a82fc1 100644
--- a/runtime/lib/identical.cc
+++ b/runtime/lib/identical.cc
@@ -8,9 +8,7 @@
 
 namespace dart {
 
-DEFINE_NATIVE_ENTRY(Identical_comparison, 2) {
-  GET_NATIVE_ARGUMENT(Instance, a, arguments->NativeArgAt(0));
-  GET_NATIVE_ARGUMENT(Instance, b, arguments->NativeArgAt(1));
+RawBool* Identical(const Instance& a, const Instance& b) {
   if (a.raw() == b.raw()) return Bool::True().raw();
   if (a.IsInteger() && b.IsInteger()) {
     return Bool::Get(a.Equals(b)).raw();
@@ -27,5 +25,11 @@ DEFINE_NATIVE_ENTRY(Identical_comparison, 2) {
   return Bool::False().raw();
 }

[siva, 2013/09/17 00:06:24]

This method should be moved into 'class Instance' in object.h
and it should return 'bool' (see comment in next file).

 
+DEFINE_NATIVE_ENTRY(Identical_comparison, 2) {
+  GET_NATIVE_ARGUMENT(Instance, a, arguments->NativeArgAt(0));
+  GET_NATIVE_ARGUMENT(Instance, b, arguments->NativeArgAt(1));
+  return Identical(a, b);

[siva, 2013/09/17 00:06:24]

return a.IsIdentical(b) ? Bool::True().raw() : Bool::False().raw();

+}
+
 
 }  // namespace dart