Make Dart_IdentityEqual live up to its spec and not leak boxing implementation detail.

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/builtin.h"
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
@@ skipping 181 matching lines @@
 
   // Same objects.
   EXPECT(Dart_IdentityEquals(five, five));
 
   // Equal objects.
   EXPECT(!Dart_IdentityEquals(five, five_again));
 
   // Different objects.
   EXPECT(!Dart_IdentityEquals(five, seven));
 
+  // Case where identical() is not the same as pointer equality.
+  Dart_Handle nan1 = Dart_NewDouble(0.0/0.0);
+  Dart_Handle nan2 = Dart_NewDouble(0.0/0.0);
+  EXPECT(Dart_IdentityEquals(nan1, nan2));
+
   // Non-instance objects.
   {
     Isolate* isolate = Isolate::Current();
     DARTSCOPE(isolate);
     Dart_Handle class1 = Api::NewHandle(isolate, Object::void_class());
     Dart_Handle class2 = Api::NewHandle(isolate, Object::class_class());
 
     EXPECT(Dart_IdentityEquals(class1, class1));
 
     EXPECT(!Dart_IdentityEquals(class1, class2));
+
+    // Mix instance and non-instance.
+    EXPECT(!Dart_IdentityEquals(class1, nan1));
+    EXPECT(!Dart_IdentityEquals(nan1, class1));
   }
 }
 
 
 TEST_CASE(ObjectEquals) {
   bool equal = false;
   Dart_Handle five = NewString("5");
   Dart_Handle five_again = NewString("5");
   Dart_Handle seven = NewString("7");
 
   // Same objects.
   EXPECT_VALID(Dart_ObjectEquals(five, five, &equal));
   EXPECT(equal);
 
   // Equal objects.
   EXPECT_VALID(Dart_ObjectEquals(five, five_again, &equal));
   EXPECT(equal);
 
   // Different objects.
   EXPECT_VALID(Dart_ObjectEquals(five, seven, &equal));
   EXPECT(!equal);
+
+  // Case where == is not the same as pointer equality.
+  Dart_Handle nan = Dart_NewDouble(0.0/0.0);
+  EXPECT_VALID(Dart_ObjectEquals(nan, nan, &equal));
+  EXPECT(!equal);
 }
 
 
 TEST_CASE(InstanceValues) {
   EXPECT(Dart_IsInstance(NewString("test")));
   EXPECT(Dart_IsInstance(Dart_True()));
 
   // By convention, our Is*() functions exclude null.
   EXPECT(!Dart_IsInstance(Dart_Null()));
 }
@@ skipping 7074 matching lines @@
                                    NewString("main"),
                                    0,
                                    NULL);
   int64_t value = 0;
   result = Dart_IntegerToInt64(result, &value);
   EXPECT_VALID(result);
   EXPECT_EQ(8, value);
 }
 
 }  // namespace dart