Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 23464058: Allow implicit conversion of acceptList values to string during Object.observe (Closed)

Created:
7 years, 3 months ago by rafaelw
Modified:
7 years, 3 months ago
Reviewers:
rossberg
CC:
v8-dev, arv (Not doing code reviews), adamk
Visibility:
Public.

Description

Allow implicit conversion of acceptList values to string during Object.observe R=rossberg@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=16703

Patch Set 1 #

Patch Set 2 : whitespace #

Total comments: 2

Patch Set 3 : cr changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M src/object-observe.js View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/harmony/object-observe.js View 1 2 3 chunks +28 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rafaelw
7 years, 3 months ago (2013-09-10 19:43:31 UTC) #1
rossberg
Is there a strong motivation for disallowing empty accept lists? IME, artificial discontinuities like that ...
7 years, 3 months ago (2013-09-11 10:51:02 UTC) #2
rafaelw
PTAL https://codereview.chromium.org/23464058/diff/2001/test/mjsunit/harmony/object-observe.js File test/mjsunit/harmony/object-observe.js (right): https://codereview.chromium.org/23464058/diff/2001/test/mjsunit/harmony/object-observe.js#newcode123 test/mjsunit/harmony/object-observe.js:123: ['foo', 'bar', 'baz'])); Done. On 2013/09/11 10:51:02, rossberg ...
7 years, 3 months ago (2013-09-11 20:58:55 UTC) #3
rossberg
LGTM, will land when tree is green
7 years, 3 months ago (2013-09-12 11:16:18 UTC) #4
rossberg
7 years, 3 months ago (2013-09-13 08:09:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r16703 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698