Avoid MSB8012 in GYP

test/target/target.gyp

Index: test/target/target.gyp
diff --git a/test/hello/hello.gyp b/test/target/target.gyp
similarity index 52%
copy from test/hello/hello.gyp
copy to test/target/target.gyp
index 1974d51ccd1934cfc0841f26e7118448b2fb1c98..592d1f401b292d96915c351e93a0568948c25c6a 100644
--- a/test/hello/hello.gyp
+++ b/test/target/target.gyp
@@ -1,4 +1,5 @@
-# Copyright (c) 2009 Google Inc. All rights reserved.
+# Copyright (C) 2013 Opera Software ASA.  All rights reserved.
+# This file is an original work developed by Opera Software ASA
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
@@ -6,10 +7,12 @@
   'targets': [
     {
       'target_name': 'hello',
+      'product_extension': 'stuff',
+      'target_extension': 'stuff',

[Nico, 2013/09/17 17:11:54]

So would one always set this for every target that sets product_extension? In
that case, shouldn't product_extension just implicitly do this as a side effect
for msvc?

[sigbjorn, 2013/09/18 08:21:27]

MSB8012 is thrown when the two are different, so a simple fix would be to ensure
they are always the same. Though presumably there is a reason for why msvc has
the two of them separate, tying them together in GYP would make GYP less
flexible.

Note that the default setup in Opera's GYP files is that the target_extension is
set automatically based on the configuration type (e.g. Dynamic library (.dll)),
and the product extension based on the target extension. (I presume that
Chromium is similar.) So after the GYP fix, the fix was to change
"product_extension:.pyd" to "target_extension:.pyd", not to add another line, so
in a setup like that, there is no need for both of the declarations. (Although
since ninja does not support target_extension, product_extension had to be kept
in the .gyp file anyhow...)

[Nico, 2013/09/18 17:38:24]

Do you need this flexibility?

[sigbjorn, 2013/09/19 07:49:03]

No. At least not right now at Opera.

       'type': 'executable',
       'sources': [
         'hello.c',
       ],
-    },
-  ],
+    }
+  ]
 }