Issue 23464038: ninja: Don't write subninjas for ninja files that end up being empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23464038: ninja: Don't write subninjas for ninja files that end up being empty. (Closed)

Created:
7 years, 3 months ago by Nico

Modified:
7 years, 3 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

ninja: Don't write subninjas for ninja files that end up being empty. r1719

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	pylib/gyp/generator/ninja.py	View		2 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm As noted, they'll never be empty on Windows unfortunately, but we can fix that ...

7 years, 3 months ago (2013-09-07 00:34:50 UTC) #2

M-A Ruel

7 years, 3 months ago (2013-09-07 21:09:35 UTC) #3

Message was sent while issue was closed.

On 2013/09/07 00:34:50, scottmg wrote:
> lgtm
> 
> As noted, they'll never be empty on Windows unfortunately, but we can fix that
> separately. Next Friday!

Please, as Windows is our slowest platform.

Expand Messages | Collapse Messages