Net: make IsSafePortableRelativePath look for reserved names on all components.

net/base/net_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NET_UTIL_H_
 #define NET_BASE_NET_UTIL_H_
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
@@ skipping 280 matching lines @@
 
 // Similar to GetSuggestedFilename(), but returns a FilePath.
 NET_EXPORT base::FilePath GenerateFileName(
     const GURL& url,
     const std::string& content_disposition,
     const std::string& referrer_charset,
     const std::string& suggested_name,
     const std::string& mime_type,
     const std::string& default_name);
 
-// Valid basenames:
+// Valid components:
 // * are not empty
 // * are not Windows reserved names (CON, NUL.zip, etc.)
-// * are just basenames
 // * do not have trailing separators
 // * do not equal kCurrentDirectory
 // * do not reference the parent directory
 // * are valid path components, which:

[asanka, 2013/09/06 21:19:31]

Nit: This line and the extra level of indent isn't needed anymore.

 // - * are not the empty string
 // - * do not contain illegal characters
 // - * do not end with Windows shell-integrated extensions (even on posix)
 // - * do not begin with '.' (which would hide them in most file managers)
 // - * do not end with ' ' or '.'
-NET_EXPORT bool IsSafePortableBasename(const base::FilePath& path);
+NET_EXPORT bool IsSafePortablePathComponent(const base::FilePath& component);
 
 // Basenames of valid relative paths are IsSafePortableBasename(), and internal
 // path components of valid relative paths are valid path components as
 // described above IsSafePortableBasename(). Valid relative paths are not
 // absolute paths.
 NET_EXPORT bool IsSafePortableRelativePath(const base::FilePath& path);
 
 // Ensures that the filename and extension is safe to use in the filesystem.
 //
 // Assumes that |file_path| already contains a valid path or file name.  On
@@ skipping 214 matching lines @@
   WIFI_PHY_LAYER_PROTOCOL_UNKNOWN
 };
 
 // Characterize the PHY mode of the currently associated access point.
 // Currently only available on OS_WIN.
 NET_EXPORT WifiPHYLayerProtocol GetWifiPHYLayerProtocol();
 
 }  // namespace net
 
 #endif  // NET_BASE_NET_UTIL_H_