Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 23464034: Set MaxDrawBuffers to 1 if WEBGL_draw_buffers is not enabled in WebGL. (Closed)

Created:
7 years, 3 months ago by Zhenyao Mo
Modified:
7 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Set MaxDrawBuffers to 1 if WEBGL_draw_buffers is not enabled in WebGL. BUG= TEST=webgl conformance tests R=bajones@chromium.org, kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Zhenyao Mo
This is a minor fix. I updated the WEBGL_draw_buffers spec recently per discussion with kbr, ...
7 years, 3 months ago (2013-09-04 22:20:53 UTC) #1
bajones
lgtm
7 years, 3 months ago (2013-09-04 22:26:54 UTC) #2
Ken Russell (switch to Gerrit)
Is there already a test which verifies this behavior?
7 years, 3 months ago (2013-09-04 22:35:22 UTC) #3
Zhenyao Mo
On 2013/09/04 22:35:22, Ken Russell wrote: > Is there already a test which verifies this ...
7 years, 3 months ago (2013-09-04 22:37:49 UTC) #4
Ken Russell (switch to Gerrit)
OK, thanks. LGTM
7 years, 3 months ago (2013-09-04 22:39:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/23464034/1
7 years, 3 months ago (2013-09-04 22:46:48 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-04 23:11:06 UTC) #7
Zhenyao Mo
7 years, 3 months ago (2013-09-05 00:15:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r221316 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698