Issue 23464029: Make adb_profile_chrome wait longer before downloading trace file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23464029: Make adb_profile_chrome wait longer before downloading trace file (Closed)

Created:
7 years, 3 months ago by Sami

Modified:
7 years, 3 months ago

Reviewers:
Tom Hudson, tomhudson

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make adb_profile_chrome wait longer before downloading trace file Reintroduce the delay to adb_profile_chrome before it attempts to download a trace file. This reduces the chances that a partially written trace file gets downloaded. NOTRY=true

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/android/adb_profile_chrome	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sami

7 years, 3 months ago (2013-09-04 16:22:01 UTC) #3

Message was sent while issue was closed.

Landed as r221190, although I don't know why it wasn't reflected here.

Expand Messages | Collapse Messages