Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 23464014: Fix accidential inclusion of <intrin.h> into namespace v8::internal. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix accidential inclusion of <intrin.h> into namespace v8::internal. Also cleanup the fallback __cpuid() implementation, and add a comment about preserving the GOT pointer in case of PIC. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16386

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M src/cpu.cc View 2 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Andreas, Small bugfix, PTAL. -- Benedikt
7 years, 3 months ago (2013-08-28 09:40:06 UTC) #1
rossberg
lgtm
7 years, 3 months ago (2013-08-28 09:48:21 UTC) #2
Benedikt Meurer
7 years, 3 months ago (2013-08-28 09:53:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16386.

Powered by Google App Engine
This is Rietveld 408576698