Compute sticky position constraints without considering transforms.

Compute sticky position constraints without considering transforms.

Sticky position is a layout offset and should not be affected by transforms.

BUG=648683
TEST=LayoutBoxModelObjectTest.StickyPositionTransforms

Committed: https://crrev.com/3e7e8fe5f7ca924f2dffe5a251f48038e85f8e91
Cr-Commit-Position: refs/heads/master@{#419954}

[flackr, 2016-09-20 19:42:34]

flackr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[flackr, 2016-09-20 19:42:35]

Hi Chris,

I noticed that localToAncestorQuad implicitly includes transforms in the offset,
which are not supposed to affect the sticky offset (see example on bug). I've
updated the code to directly call mapLocalToAncestor so that we can not include
transforms.

Since we're not considering transforms I was also able to remove the double call
to localToAncestorQuad because we can in fact use the same rect to compute the
containing block constraint as we use for the sticky box rect position.

Please take a look. This should be mostly tested by the existing tests (I of
course added one that tests constraints are not affected by transform). Let me
know if you think I should add a LayoutTest similar to the one on the bug I
filed.

Thanks,
Rob

[chrishtr, 2016-09-21 00:14:22]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-21 00:14:23]

lgtm

[commit-bot: I haz the power, 2016-09-21 00:14:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 02:38:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 02:40:20]

Description was changed from

==========
Compute sticky position constraints without considering transforms.

Sticky position is a layout offset and should not be affected by transforms.

BUG=648683
TEST=LayoutBoxModelObjectTest.StickyPositionTransforms
==========

to

==========
Compute sticky position constraints without considering transforms.

Sticky position is a layout offset and should not be affected by transforms.

BUG=648683
TEST=LayoutBoxModelObjectTest.StickyPositionTransforms

Committed: https://crrev.com/3e7e8fe5f7ca924f2dffe5a251f48038e85f8e91
Cr-Commit-Position: refs/heads/master@{#419954}
==========

[commit-bot: I haz the power, 2016-09-21 02:40:21]

Patchset 1 (id:??) landed as
https://crrev.com/3e7e8fe5f7ca924f2dffe5a251f48038e85f8e91
Cr-Commit-Position: refs/heads/master@{#419954}