Split SkFontConfigInterface globals and factory.

Split SkFontConfigInterface globals and factory.

Chromium needs to be able to set up their build such that the globals
continue existing but the SkFontMgr::Factory can be defined separately.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346333002
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed: https://skia.googlesource.com/skia/+/1ae0e01accbca4b96a10b8a8c21917dd7bf27dc3

[bungeman-skia, 2016-09-19 18:25:49]

Description was changed from

==========
Split SkFontConfigInterface globals and factory.

Chromium needs to be able to set up their build such that the globals
continue existing but the SkFontMgr::Factory can be defined separately.
==========

to

==========
Split SkFontConfigInterface globals and factory.

Chromium needs to be able to set up their build such that the globals
continue existing but the SkFontMgr::Factory can be defined separately.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346333002
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[bungeman-skia, 2016-09-19 18:26:17]

Description was changed from

==========
Split SkFontConfigInterface globals and factory.

Chromium needs to be able to set up their build such that the globals
continue existing but the SkFontMgr::Factory can be defined separately.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346333002
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Split SkFontConfigInterface globals and factory.

Chromium needs to be able to set up their build such that the globals
continue existing but the SkFontMgr::Factory can be defined separately.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346333002
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[bungeman-skia, 2016-09-19 18:28:33]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:28:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-09-19 18:37:44]

bungeman@google.com changed reviewers:
+ reed@google.com

[commit-bot: I haz the power, 2016-09-19 18:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 18:45:51]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-09-19 19:10:08]

lgtm

https://codereview.chromium.org/2346333002/diff/1/include/ports/SkFontConfigI...
File include/ports/SkFontConfigInterface.h (right):

https://codereview.chromium.org/2346333002/diff/1/include/ports/SkFontConfigI...
include/ports/SkFontConfigInterface.h:33: static SkFontConfigInterface*
RefGlobal();
sk_sp<...> ?

[bungeman-skia, 2016-09-19 19:11:27]

https://codereview.chromium.org/2346333002/diff/1/include/ports/SkFontConfigI...
File include/ports/SkFontConfigInterface.h (right):

https://codereview.chromium.org/2346333002/diff/1/include/ports/SkFontConfigI...
include/ports/SkFontConfigInterface.h:33: static SkFontConfigInterface*
RefGlobal();
On 2016/09/19 19:10:08, reed1 wrote:
> sk_sp<...> ?

Yeah, that needs to be done too.

[bungeman-skia, 2016-09-19 19:11:36]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-09-19 19:11:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-09-19 19:11:46]

The CQ bit was unchecked by bungeman@google.com

[bungeman-skia, 2016-09-19 19:12:06]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-09-19 19:12:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:13:17]

Description was changed from

==========
Split SkFontConfigInterface globals and factory.

Chromium needs to be able to set up their build such that the globals
continue existing but the SkFontMgr::Factory can be defined separately.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346333002
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Split SkFontConfigInterface globals and factory.

Chromium needs to be able to set up their build such that the globals
continue existing but the SkFontMgr::Factory can be defined separately.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346333002
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/1ae0e01accbca4b96a10b8a8c21917dd7bf27dc3
==========

[commit-bot: I haz the power, 2016-09-19 19:13:18]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1ae0e01accbca4b96a10b8a8c21917dd7bf27dc3