Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 23463047: Add field nested_sites to AllocationSite. (Closed)

Created:
7 years, 3 months ago by mvstanton
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add field nested_sites to AllocationSite. This field is used to maintain allocation site information for nested array and object literals. It's not used productively in this CL, merely maintained in a minimal way. (that comes next :)). BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16912

Patch Set 1 #

Patch Set 2 : A few more changes #

Total comments: 7

Patch Set 3 : Removed unnecessary calls #

Patch Set 4 : Comment responsio. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M src/code-stubs-hydrogen.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M src/objects-printer.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hi Hannes, here is the field needed for nested literals, PTAL, thanks! --Michael
7 years, 3 months ago (2013-09-20 12:57:02 UTC) #1
Hannes Payer (out of office)
LGTM, few nits. https://codereview.chromium.org/23463047/diff/3001/src/heap-snapshot-generator.cc File src/heap-snapshot-generator.cc (right): https://codereview.chromium.org/23463047/diff/3001/src/heap-snapshot-generator.cc#newcode1304 src/heap-snapshot-generator.cc:1304: SetInternalReference(site, entry, "nested_sites", site->nested_sites(), same same ...
7 years, 3 months ago (2013-09-24 08:04:40 UTC) #2
mvstanton
Thanks Hannes! --Michael https://codereview.chromium.org/23463047/diff/3001/src/objects-printer.cc File src/objects-printer.cc (right): https://codereview.chromium.org/23463047/diff/3001/src/objects-printer.cc#newcode1106 src/objects-printer.cc:1106: // Just print the number of ...
7 years, 3 months ago (2013-09-24 08:39:15 UTC) #3
mvstanton
7 years, 3 months ago (2013-09-24 10:30:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r16912 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698