Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23463037: Revert 223482 "Simplify PPB_NetworkMonitor proxy." (Closed)

Created:
7 years, 3 months ago by Bei Zhang
Modified:
7 years, 3 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 223482 "Simplify PPB_NetworkMonitor proxy." > Simplify PPB_NetworkMonitor proxy. > > The new proxy is based on ppapi::proxy::PluginResource and > ppapi::host::ResourceHost which simplifies code significantly. Also > the permission check is consistent with socket APIs now. > > BUG=281781 > > Review URL: https://chromiumcodereview.appspot.com/23819033 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -505 lines) Patch
M trunk/src/content/browser/ppapi_plugin_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_message_filter.h View 2 chunks +33 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_message_filter.cc View 3 chunks +97 lines, -3 lines 0 comments Download
D trunk/src/content/browser/renderer_host/pepper/pepper_network_monitor_host.h View 1 chunk +0 lines, -50 lines 0 comments Download
D trunk/src/content/browser/renderer_host/pepper/pepper_network_monitor_host.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M trunk/src/content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/ppapi_plugin/ppapi_thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/content/public/common/socket_permission_request.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/ppapi/ppapi_proxy.gypi View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/ppapi/ppapi_shared.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/ppapi/proxy/interface_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
D trunk/src/ppapi/proxy/network_list_resource.h View 1 chunk +0 lines, -52 lines 0 comments Download
D trunk/src/ppapi/proxy/network_list_resource.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D trunk/src/ppapi/proxy/network_monitor_resource.h View 1 chunk +0 lines, -58 lines 0 comments Download
D trunk/src/ppapi/proxy/network_monitor_resource.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M trunk/src/ppapi/proxy/ppapi_messages.h View 6 chunks +13 lines, -9 lines 0 comments Download
A + trunk/src/ppapi/proxy/ppb_network_monitor_private_proxy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ppapi/proxy/ppb_network_monitor_private_proxy.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ppapi/proxy/resource_creation_proxy.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/ppapi/proxy/serialized_structs.h View 2 chunks +0 lines, -15 lines 0 comments Download
M trunk/src/ppapi/proxy/serialized_structs.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/ppapi/shared_impl/api_id.h View 1 chunk +1 line, -0 lines 0 comments Download
A + trunk/src/ppapi/shared_impl/ppb_network_list_private_shared.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ppapi/shared_impl/ppb_network_list_private_shared.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ppapi/thunk/interfaces_ppb_private_no_permissions.h View 2 chunks +4 lines, -1 line 0 comments Download
M trunk/src/ppapi/thunk/ppb_network_list_api.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bei Zhang
7 years, 3 months ago (2013-09-17 00:18:36 UTC) #1
Bei Zhang
7 years, 3 months ago (2013-09-17 00:19:12 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r223484.

Powered by Google App Engine
This is Rietveld 408576698