Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Issue 23463035: Use chrome.windows to open chrome://system from Feedback. (Closed)

Created:
7 years, 3 months ago by rkc
Modified:
7 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Use chrome.windows to open chrome://system from Feedback. Use chrome.windows to create a unique window to show the user their system information when the System Information link is clicked on the feedback UI. R=xiyuan@chromium.org BUG=268681 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223563

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/browser/resources/feedback/js/feedback.js View 3 chunks +18 lines, -4 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
rkc
7 years, 3 months ago (2013-09-16 23:45:05 UTC) #1
xiyuan
https://codereview.chromium.org/23463035/diff/1/chrome/browser/resources/feedback/js/feedback.js File chrome/browser/resources/feedback/js/feedback.js (right): https://codereview.chromium.org/23463035/diff/1/chrome/browser/resources/feedback/js/feedback.js#newcode67 chrome/browser/resources/feedback/js/feedback.js:67: chrome.app.window.current().show(); Is this necessary? Could you pass focused: true ...
7 years, 3 months ago (2013-09-16 23:53:45 UTC) #2
rkc
https://codereview.chromium.org/23463035/diff/1/chrome/browser/resources/feedback/js/feedback.js File chrome/browser/resources/feedback/js/feedback.js (right): https://codereview.chromium.org/23463035/diff/1/chrome/browser/resources/feedback/js/feedback.js#newcode67 chrome/browser/resources/feedback/js/feedback.js:67: chrome.app.window.current().show(); On 2013/09/16 23:53:45, xiyuan wrote: > Is this ...
7 years, 3 months ago (2013-09-17 00:00:00 UTC) #3
xiyuan
LGTM Thanks for the explanation.
7 years, 3 months ago (2013-09-17 01:20:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/23463035/1
7 years, 3 months ago (2013-09-17 01:25:09 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 07:50:10 UTC) #6
Message was sent while issue was closed.
Change committed as 223563

Powered by Google App Engine
This is Rietveld 408576698