Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: chrome/browser/sync/glue/password_model_worker.h

Issue 23463033: Release password store on UI loop when worker is stopped so that password (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/password_model_worker.h
diff --git a/chrome/browser/sync/glue/password_model_worker.h b/chrome/browser/sync/glue/password_model_worker.h
index 5fe13268a1be14f5da219bfdb9cfc8bbdf170718..ac4030e086eebf579362a16a4b5de9e7759845be 100644
--- a/chrome/browser/sync/glue/password_model_worker.h
+++ b/chrome/browser/sync/glue/password_model_worker.h
@@ -31,6 +31,7 @@ class PasswordModelWorker : public syncer::ModelSafeWorker {
// syncer::ModelSafeWorker implementation. Called on syncapi SyncerThread.
virtual void RegisterForLoopDestruction() OVERRIDE;
virtual syncer::ModelSafeGroup GetModelSafeGroup() OVERRIDE;
+ virtual void RequestStop() OVERRIDE;
protected:
virtual syncer::SyncerError DoWorkAndWaitUntilDoneImpl(
@@ -48,6 +49,7 @@ class PasswordModelWorker : public syncer::ModelSafeWorker {
// observer.
void RegisterForPasswordLoopDestruction();
+ base::Lock password_store_lock_;
Nicolas Zea 2013/09/16 17:37:51 Comment why a lock is needed to protect the passwo
haitaol1 2013/09/16 18:07:39 Done.
scoped_refptr<PasswordStore> password_store_;
DISALLOW_COPY_AND_ASSIGN(PasswordModelWorker);
};
« no previous file with comments | « no previous file | chrome/browser/sync/glue/password_model_worker.cc » ('j') | sync/internal_api/public/engine/model_safe_worker.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698