Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 23463030: Add toSVGFEFuncR|G|B|AElement() fuctions, and use them. (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive
Modified:
7 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr, eae+blinkwatch, Stephen Chennney, f(malita), dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add toSVGFEFuncR|G|B|AElement() fuctions, and use them. These inline functions will check if type casting is correct with assertions. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M Source/core/svg/SVGFEComponentTransferElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEFuncAElement.h View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFEFuncBElement.h View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFEFuncGElement.h View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFEFuncRElement.h View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
Add tkent.
7 years, 3 months ago (2013-09-14 15:03:50 UTC) #1
tkent
lgtm
7 years, 3 months ago (2013-09-16 22:06:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23463030/1
7 years, 3 months ago (2013-09-16 22:06:48 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 23:12:15 UTC) #4
Message was sent while issue was closed.
Change committed as 157863

Powered by Google App Engine
This is Rietveld 408576698