Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2346283002: Fix build with media_use_ffmpeg=false (Closed)

Created:
4 years, 3 months ago by Julien Isorce Samsung
Modified:
4 years, 3 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build with media_use_ffmpeg=false BUG=none R=jochen@chromium.org Committed: https://crrev.com/e024287ab825e6c8c4d04a753b8cfcd05d5be405 Cr-Commit-Position: refs/heads/master@{#419713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/media_metadata_parser.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/common/feature_h264_with_openh264_ffmpeg.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/feature_h264_with_openh264_ffmpeg.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Julien Isorce Samsung
On 2016/09/19 16:36:01, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 3 months ago (2016-09-19 17:32:59 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-20 09:38:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346283002/1
4 years, 3 months ago (2016-09-20 10:01:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 10:07:25 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 10:10:45 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e024287ab825e6c8c4d04a753b8cfcd05d5be405
Cr-Commit-Position: refs/heads/master@{#419713}

Powered by Google App Engine
This is Rietveld 408576698