Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7693)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

Issue 2346263003: Adjust positioning of bookmarks bubble for Harmony. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/toolbar/toolbar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
index 3ace6d80e6b62c3c292ac3b59a23832c5b93c5e7..4cb09cab2604249767ec9f1542483f81179919aa 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
@@ -61,9 +61,15 @@ LocationBarBubbleDelegateView::LocationBarBubbleDelegateView(
content::Source<FullscreenController>(
browser->exclusive_access_manager()->fullscreen_controller()));
}
- // Compensate for built-in vertical padding in the anchor view's image.
- set_anchor_view_insets(gfx::Insets(
- GetLayoutConstant(LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET), 0));
+ if (ui::MaterialDesignController::IsSecondaryUiMaterial()) {
+ // The anchor is the location bar. The bubble's 1px border should overlap
+ // the location bar's 1px border.
+ set_anchor_view_insets(gfx::Insets(0, 0, 1, 0));
msw 2016/10/07 22:13:53 Does this look right when the bubble is flipped ve
+ } else {
+ // Compensate for built-in vertical padding in the anchor view's image.
+ set_anchor_view_insets(gfx::Insets(
+ GetLayoutConstant(LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET), 0));
+ }
}
LocationBarBubbleDelegateView::~LocationBarBubbleDelegateView() {}
« no previous file with comments | « no previous file | chrome/browser/ui/views/toolbar/toolbar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698