Adjust positioning of bookmarks bubble for Harmony.

Adjust positioning of bookmarks bubble for Harmony.

BUG=635172
Committed: https://crrev.com/85a7938b20bd11d514945e2e06d5feec2ac6daa3
Cr-Commit-Position: refs/heads/master@{#419847}

[Evan Stade, 2016-09-19 22:26:12]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-09-19 22:26:22]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2016-09-19 22:26:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-09-19 23:06:11]

Can you make sure rtl for chromeos is ok with this? I'm specifically thinking of
this patch: https://codereview.chromium.org/1866403005/

[commit-bot: I haz the power, 2016-09-20 01:26:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:26:21]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-09-20 19:35:09]

On 2016/09/19 23:06:11, sky wrote:
> Can you make sure rtl for chromeos is ok with this? I'm specifically thinking
of
> this patch: https://codereview.chromium.org/1866403005/

That is an interesting bubble. It still has an arrow right now, and it's not
clear to me if it should be removed. I did find a couple other bubbles that have
arrows (App panels on cros, the window selector bubble for shelf items, maybe
others). Sebastien says we need to kill them all, so at least we can still
proceed down the path of not supporting drawing arrows (crisis averted).

This patch does not break RTL for the overflow bubble (at least if I follow the
repro steps in the bug).

[sky, 2016-09-20 20:10:07]

Thanks for looking, LGTM

[Evan Stade, 2016-09-20 20:18:18]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-09-20 20:18:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 20:24:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-20 20:26:37]

Description was changed from

==========
Adjust positioning of bookmarks bubble for Harmony.

BUG=635172
==========

to

==========
Adjust positioning of bookmarks bubble for Harmony.

BUG=635172

Committed: https://crrev.com/85a7938b20bd11d514945e2e06d5feec2ac6daa3
Cr-Commit-Position: refs/heads/master@{#419847}
==========

[commit-bot: I haz the power, 2016-09-20 20:26:38]

Patchset 1 (id:??) landed as
https://crrev.com/85a7938b20bd11d514945e2e06d5feec2ac6daa3
Cr-Commit-Position: refs/heads/master@{#419847}

[msw, 2016-10-07 22:13:52]

msw@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2016-10-07 22:13:53]

https://codereview.chromium.org/2346263003/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
(right):

https://codereview.chromium.org/2346263003/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc:67:
set_anchor_view_insets(gfx::Insets(0, 0, 1, 0));
Does this look right when the bubble is flipped vertically?