Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 2346263002: Extending the UserClassifier to actually support classification. (Closed)
Patch Set: Comments of Tim and Marc Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/ntp_snippets_bridge.cc
diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.cc b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
index 348e5e95402663c4490ef19e4cd3896e48749ee9..47be0df9b9f3e74d433a8f8d4e3ad8b570b603ab 100644
--- a/chrome/browser/android/ntp/ntp_snippets_bridge.cc
+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
@@ -268,7 +268,8 @@ void NTPSnippetsBridge::OnPageShown(
suggestions_per_category_int[i]));
}
ntp_snippets::metrics::OnPageShown(suggestions_per_category);
- content_suggestions_service_->user_classifier()->OnNTPOpened();
+ content_suggestions_service_->user_classifier()->OnEvent(
+ ntp_snippets::UserClassifier::Metric::NTP_OPENED);
Marc Treib 2016/09/20 13:26:52 misaligned
}
void NTPSnippetsBridge::OnSuggestionShown(JNIEnv* env,
@@ -282,7 +283,8 @@ void NTPSnippetsBridge::OnSuggestionShown(JNIEnv* env,
global_position, CategoryFromIDValue(category), category_position,
TimeFromJavaTime(publish_timestamp_ms), score);
if (global_position == 0)
- content_suggestions_service_->user_classifier()->OnSuggestionsShown();
+ content_suggestions_service_->user_classifier()->OnEvent(
+ ntp_snippets::UserClassifier::Metric::SUGGESTIONS_SHOWN);
}
void NTPSnippetsBridge::OnSuggestionOpened(JNIEnv* env,
@@ -297,7 +299,8 @@ void NTPSnippetsBridge::OnSuggestionOpened(JNIEnv* env,
global_position, CategoryFromIDValue(category), category_position,
TimeFromJavaTime(publish_timestamp_ms), score,
static_cast<WindowOpenDisposition>(windowOpenDisposition));
- content_suggestions_service_->user_classifier()->OnSuggestionsUsed();
+ content_suggestions_service_->user_classifier()->OnEvent(
+ ntp_snippets::UserClassifier::Metric::SUGGESTIONS_USED);
}
void NTPSnippetsBridge::OnSuggestionMenuOpened(JNIEnv* env,
@@ -326,7 +329,8 @@ void NTPSnippetsBridge::OnMoreButtonClicked(JNIEnv* env,
jint position) {
ntp_snippets::metrics::OnMoreButtonClicked(CategoryFromIDValue(category),
position);
- content_suggestions_service_->user_classifier()->OnSuggestionsUsed();
+ content_suggestions_service_->user_classifier()->OnEvent(
+ ntp_snippets::UserClassifier::Metric::SUGGESTIONS_USED);
}
NTPSnippetsBridge::~NTPSnippetsBridge() {}

Powered by Google App Engine
This is Rietveld 408576698