Update PseudoElements during recalcStyle.

Update PseudoElements during recalcStyle.

Update PseudoElements during recalcStyle. If the pseudoStyles have changed,
ensure layoutObject triggers setStyle.

BUG=492785
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/b7f5abb9c6374727928fd955052f53811cfe6a90
Cr-Commit-Position: refs/heads/master@{#421755}

[MuVen, 2016-09-19 07:18:22]

Description was changed from

==========
done


done

BUG=
==========

to

==========
done


done

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[MuVen, 2016-09-19 07:19:05]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 07:19:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[MuVen, 2016-09-19 07:19:26]

Description was changed from

==========
done


done

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
IFrame Scrollbar needs reconstruction [RLS]

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[MuVen, 2016-09-19 07:19:34]

Patchset #1 (id:1) has been deleted

[MuVen, 2016-09-19 07:20:03]

Description was changed from

==========
IFrame Scrollbar needs reconstruction [RLS]

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
IFrame Scrollbar needs reconstruction [RLS]

BUG=492785
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-09-19 08:20:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 08:20:53]

Dry run: This issue passed the CQ dry run.

[MuVen, 2016-09-19 08:35:27]

sataya.m@samsung.com changed reviewers:
+ skobes@chromium.org

[MuVen, 2016-09-19 08:35:28]

Skobes PTAL.

The root cause of this issue is as follows:

Iframe platform scrollbar are created at PLSA for RLS.

on inserting style:

sheet.insertRule("::-webkit-scrollbar { width: 50px; height: 20px; }", 0);

PLSA::updateAfterStyleChange is called and the box overflow is 0 and 
needsHorizontalScrollbar is set to false destroying the platform scrollbars. 

frameView->needsScrollbarReconstruction() at LayoutPart::updateWidgetGeometry 
returns false as during the styleUpdate platform scrollbars are destoryed, 
though i modifed to check PLSA scrollbars in the 
FrameView::needsScrollbarReconstruction() API (in RLS).

So during Style update is we have scrollbars before updateAfterStyleChange and 
destoryed after updating style im setting the frameView needsLayout.

Let me know your thoughts on this patch.

[skobes, 2016-09-19 19:32:20]

Why doesn't LayoutObject::styleDidChange invalidate the layout properly?

[MuVen, 2016-09-20 10:42:24]

On 2016/09/19 19:32:20, skobes wrote:
> Why doesn't LayoutObject::styleDidChange invalidate the layout properly?

These statements 

if (!m_parent)
    return;

in the LayoutObject::styleDidChange is stopping Frameview to invalidate.

[MuVen, 2016-09-22 06:31:54]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 06:32:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[MuVen, 2016-09-22 06:34:04]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 06:34:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[MuVen, 2016-09-22 06:34:45]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-09-22 06:36:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 06:36:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[MuVen, 2016-09-22 06:52:06]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 06:52:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[MuVen, 2016-09-22 06:52:25]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-09-22 07:57:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 07:57:26]

Dry run: This issue passed the CQ dry run.

[MuVen, 2016-09-22 15:30:09]

PTAL.

[skobes, 2016-09-22 20:11:23]

I think the problem is not specific to RLS, or to iframes.

For example in https://output.jsbin.com/kepewe/quiet the scrollbars should
change from native to custom but they don't, even with this patch.

The early return when m_parent is null affects the LayoutView, but the frame
scrollbars are controlled by css styling on the <html> element, whose m_parent
is not null.

I suspect the problem is that the StyleDifference created in
LayoutObject::setStyle is not marked as needing layout when we recalc style on
the <html> element.

But that's surprising since
ComputedStyle::diffNeedsFullLayoutAndPaintInvalidation has a check for
PseudoIdScrollbar.  I wonder why we're not hitting that.

[MuVen, 2016-09-23 08:03:44]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 08:03:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 09:01:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 09:01:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[MuVen, 2016-09-23 12:06:35]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 12:06:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[MuVen, 2016-09-23 12:20:35]

Hi Skobes,

Found the real culprit :)

On inserting Style change after timeout, All elements recalc their own style.
In this process at Element::recalcOwnStyle , ComputedStyle::stylePropagationDiff
says their is no style change because of this setStyleInternal is called.
The patch checks diffPseudoStyles and returns UpdatePseudoElements
oldStyle.hasPseudoStyle(pseudoId) != newStyle.hasPseudoStyle(pseudoId).

Let me know your comments on this.

Thanks,

[MuVen, 2016-09-23 12:23:10]

Description was changed from

==========
IFrame Scrollbar needs reconstruction [RLS]

BUG=492785
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Update UpdatePseudoElements on recalcStyle.


Update UpdatePseudoElements on recalcStyle. If the new style has 
pseudo elements call layoutObjects setStyle which evaluates and
validates the needForLayout.

BUG=492785
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-09-23 12:27:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 12:27:34]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[skobes, 2016-09-24 00:11:39]

https://codereview.chromium.org/2346213002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (left):

https://codereview.chromium.org/2346213002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:173: if
(!oldStyle.hasAnyPublicPseudoStyles())
We should avoid looping in the common case that neither oldStyle nor newStyle
has pseudo styles.  Can we just update the condition here to be:

if (!oldStyle.hasAnyPublicPseudoStyles() &&
!newStyle.hasAnyPublicPseudoStyles())

https://codereview.chromium.org/2346213002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2346213002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:173: for (PseudoId
pseudoId = FirstPublicPseudoId; pseudoId < FirstInternalPseudoId; pseudoId =
static_cast<PseudoId>(pseudoId + 1)) {
Instead of adding another loop let's update the main loop below to only skip if
neither oldStyle nor newStyle has the pseudo style for that id.

[MuVen, 2016-09-26 03:47:01]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 03:47:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 05:05:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 05:05:44]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[MuVen, 2016-09-26 06:49:42]

Patchset #4 (id:120001) has been deleted

[MuVen, 2016-09-26 06:54:29]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 06:54:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[MuVen, 2016-09-26 07:46:02]

Description was changed from

==========
Update UpdatePseudoElements on recalcStyle.


Update UpdatePseudoElements on recalcStyle. If the new style has 
pseudo elements call layoutObjects setStyle which evaluates and
validates the needForLayout.

BUG=492785
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Update PseudoElements during recalcStyle.


Update PseudoElements during recalcStyle. If the pseudoStyles have changed,
ensure layoutObject triggers setStyle.

BUG=492785
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[MuVen, 2016-09-26 07:46:15]

Description was changed from

==========
Update PseudoElements during recalcStyle.


Update PseudoElements during recalcStyle. If the pseudoStyles have changed,
ensure layoutObject triggers setStyle.

BUG=492785
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Update PseudoElements during recalcStyle.

Update PseudoElements during recalcStyle. If the pseudoStyles have changed,
ensure layoutObject triggers setStyle.

BUG=492785
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-09-26 09:23:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 09:23:43]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[MuVen, 2016-09-26 09:25:24]

The CQ bit was checked by sataya.m@samsung.com

[MuVen, 2016-09-26 09:25:38]

The CQ bit was unchecked by sataya.m@samsung.com

[MuVen, 2016-09-26 09:41:18]

The CQ bit was checked by sataya.m@samsung.com

[MuVen, 2016-09-26 09:41:37]

The CQ bit was unchecked by sataya.m@samsung.com

[MuVen, 2016-09-26 14:53:19]

PTAL.

[MuVen, 2016-09-27 16:05:42]

friendly ping !!!

[skobes, 2016-09-28 22:10:20]

lgtm

[MuVen, 2016-09-29 00:14:46]

The CQ bit was checked by sataya.m@samsung.com

[commit-bot: I haz the power, 2016-09-29 00:15:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 00:18:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 00:18:15]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[MuVen, 2016-09-29 04:01:52]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 04:02:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[MuVen, 2016-09-29 04:02:54]

The CQ bit was unchecked by sataya.m@samsung.com

[MuVen, 2016-09-29 04:02:55]

The CQ bit was checked by sataya.m@samsung.com

[MuVen, 2016-09-29 04:02:55]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2346213002/#ps160001
(title: "Rebase to latest")

[commit-bot: I haz the power, 2016-09-29 04:03:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 05:19:52]

Description was changed from

==========
Update PseudoElements during recalcStyle.

Update PseudoElements during recalcStyle. If the pseudoStyles have changed,
ensure layoutObject triggers setStyle.

BUG=492785
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Update PseudoElements during recalcStyle.

Update PseudoElements during recalcStyle. If the pseudoStyles have changed,
ensure layoutObject triggers setStyle.

BUG=492785
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-09-29 05:19:54]

Committed patchset #5 (id:160001)

[commit-bot: I haz the power, 2016-09-29 05:23:11]

Description was changed from

==========
Update PseudoElements during recalcStyle.

Update PseudoElements during recalcStyle. If the pseudoStyles have changed,
ensure layoutObject triggers setStyle.

BUG=492785
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Update PseudoElements during recalcStyle.

Update PseudoElements during recalcStyle. If the pseudoStyles have changed,
ensure layoutObject triggers setStyle.

BUG=492785
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/b7f5abb9c6374727928fd955052f53811cfe6a90
Cr-Commit-Position: refs/heads/master@{#421755}
==========

[commit-bot: I haz the power, 2016-09-29 05:23:12]

Patchset 5 (id:??) landed as
https://crrev.com/b7f5abb9c6374727928fd955052f53811cfe6a90
Cr-Commit-Position: refs/heads/master@{#421755}