Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 23462016: Revert 219911 "Pepper: Move FileRef to the "new" resource proxy." (Closed)

Created:
7 years, 3 months ago by teravest
Modified:
7 years, 3 months ago
Reviewers:
teravest
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 219911 "Pepper: Move FileRef to the "new" resource proxy." There have been multiple test failures among users of the CRX filesystem, which is not adequately tested by existing tests. I'm not sure at all what's broken, but I guess I'll have to do manual testing to sort it out. > Pepper: Move FileRef to the "new" resource proxy. > > This change moves the FileRef implementation from the previous one in the "old" > resource model (ppb_file_ref_impl.cc) to the "new" resource model > (pepper_file_ref_host.cc), and from the renderer to the browser. > > As many as possible of the supporting changes were split off to other changes > to minimize the size of this change. Unfortunately, a lot of changes for > URLLoader had to be rolled into this change. > > The data structures for CreateInfo have changed, and all users of FileRef have > to be moved over, which is what causes this change to be so large. > > TBR=dmichael@chromium.org, jschuh@chromium.org, yzshen@chromium.org > BUG=225441 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216744 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218305 > > Review URL: https://chromiumcodereview.appspot.com/21966004 TBR=teravest@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -540 lines) Patch
MM trunk/src/chrome/renderer/pepper/pepper_flash_drm_renderer_host.h View 2 chunks +0 lines, -12 lines 0 comments Download
M trunk/src/chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc View 3 chunks +9 lines, -31 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_file_ref_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_renderer_connection.h View 2 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_renderer_connection.cc View 4 chunks +15 lines, -22 lines 0 comments Download
M trunk/src/content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/content/public/renderer/pepper_plugin_instance.h View 2 chunks +6 lines, -0 lines 0 comments Download
M trunk/src/content/public/renderer/renderer_ppapi_host.h View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/content/renderer/pepper/mock_renderer_ppapi_host.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_browser_connection.h View 3 chunks +8 lines, -3 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_browser_connection.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_file_chooser_host.h View 2 chunks +0 lines, -10 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_file_chooser_host.cc View 4 chunks +18 lines, -45 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_file_chooser_host_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_file_io_host.h View 4 chunks +1 line, -8 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_file_io_host.cc View 4 chunks +24 lines, -46 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_in_process_resource_creation.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_in_process_resource_creation.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_plugin_instance_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_plugin_instance_impl.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_url_loader_host.cc View 2 chunks +1 line, -6 lines 0 comments Download
M trunk/src/content/renderer/pepper/pepper_url_request_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
A + trunk/src/content/renderer/pepper/ppb_file_ref_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/renderer/pepper/ppb_file_ref_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/renderer/pepper/resource_creation_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/pepper/resource_creation_impl.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/pepper/url_request_info_util.h View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/content/renderer/pepper/url_request_info_util.cc View 7 chunks +39 lines, -40 lines 0 comments Download
M trunk/src/content/renderer/pepper/url_response_info_util.h View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/content/renderer/pepper/url_response_info_util.cc View 3 chunks +14 lines, -33 lines 0 comments Download
M trunk/src/ppapi/ppapi_proxy.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/ppapi/ppapi_shared.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ppapi/proxy/file_chooser_resource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ppapi/proxy/file_chooser_resource.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M trunk/src/ppapi/proxy/file_chooser_resource_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/ppapi/proxy/file_io_resource.h View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/ppapi/proxy/file_io_resource.cc View 2 chunks +1 line, -8 lines 0 comments Download
M trunk/src/ppapi/proxy/file_ref_resource.h View 4 chunks +11 lines, -5 lines 0 comments Download
M trunk/src/ppapi/proxy/file_ref_resource.cc View 7 chunks +33 lines, -6 lines 0 comments Download
M trunk/src/ppapi/proxy/flash_drm_resource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ppapi/proxy/flash_drm_resource.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M trunk/src/ppapi/proxy/flash_file_resource.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ppapi/proxy/interface_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ppapi/proxy/ppapi_messages.h View 11 chunks +75 lines, -26 lines 0 comments Download
M trunk/src/ppapi/proxy/ppapi_param_traits.h View 3 chunks +19 lines, -0 lines 0 comments Download
M trunk/src/ppapi/proxy/ppapi_param_traits.cc View 2 chunks +52 lines, -0 lines 0 comments Download
A + trunk/src/ppapi/proxy/ppb_file_ref_proxy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ppapi/proxy/ppb_file_ref_proxy.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ppapi/proxy/resource_creation_proxy.h View 1 chunk +4 lines, -2 lines 0 comments Download
M trunk/src/ppapi/proxy/resource_creation_proxy.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M trunk/src/ppapi/proxy/url_loader_resource.cc View 5 chunks +10 lines, -18 lines 0 comments Download
M trunk/src/ppapi/proxy/url_response_info_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ppapi/shared_impl/file_ref_create_info.h View 2 chunks +2 lines, -17 lines 0 comments Download
D trunk/src/ppapi/shared_impl/file_ref_create_info.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D trunk/src/ppapi/shared_impl/file_ref_detailed_info.h View 1 chunk +0 lines, -28 lines 0 comments Download
A + trunk/src/ppapi/shared_impl/ppb_file_ref_shared.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ppapi/shared_impl/ppb_file_ref_shared.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ppapi/shared_impl/url_request_info_data.h View 2 chunks +14 lines, -9 lines 0 comments Download
M trunk/src/ppapi/shared_impl/url_request_info_data.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/ppapi/shared_impl/url_response_info_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ppapi/thunk/interfaces_ppb_private.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ppapi/thunk/interfaces_ppb_public_stable.h View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/ppapi/thunk/ppb_file_ref_api.h View 2 chunks +17 lines, -3 lines 0 comments Download
M trunk/src/ppapi/thunk/ppb_file_ref_thunk.cc View 2 chunks +1 line, -7 lines 0 comments Download
M trunk/src/ppapi/thunk/resource_creation_api.h View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
teravest
7 years, 3 months ago (2013-08-29 02:15:30 UTC) #1
teravest
7 years, 3 months ago (2013-08-29 02:15:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r220165.

Powered by Google App Engine
This is Rietveld 408576698