Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: src/hydrogen-instructions.h

Issue 23462007: Delete HAbnormalExit. It does more harm than good. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-environment-liveness.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 56
57 #define HYDROGEN_ABSTRACT_INSTRUCTION_LIST(V) \ 57 #define HYDROGEN_ABSTRACT_INSTRUCTION_LIST(V) \
58 V(ArithmeticBinaryOperation) \ 58 V(ArithmeticBinaryOperation) \
59 V(BinaryOperation) \ 59 V(BinaryOperation) \
60 V(BitwiseBinaryOperation) \ 60 V(BitwiseBinaryOperation) \
61 V(ControlInstruction) \ 61 V(ControlInstruction) \
62 V(Instruction) \ 62 V(Instruction) \
63 63
64 64
65 #define HYDROGEN_CONCRETE_INSTRUCTION_LIST(V) \ 65 #define HYDROGEN_CONCRETE_INSTRUCTION_LIST(V) \
66 V(AbnormalExit) \
67 V(AccessArgumentsAt) \ 66 V(AccessArgumentsAt) \
68 V(Add) \ 67 V(Add) \
69 V(Allocate) \ 68 V(Allocate) \
70 V(ApplyArguments) \ 69 V(ApplyArguments) \
71 V(ArgumentsElements) \ 70 V(ArgumentsElements) \
72 V(ArgumentsLength) \ 71 V(ArgumentsLength) \
73 V(ArgumentsObject) \ 72 V(ArgumentsObject) \
74 V(Bitwise) \ 73 V(Bitwise) \
75 V(BlockEntry) \ 74 V(BlockEntry) \
76 V(BoundsCheck) \ 75 V(BoundsCheck) \
(...skipping 1359 matching lines...) Expand 10 before | Expand all | Expand 10 after
1436 1435
1437 private: 1436 private:
1438 HReturn(HValue* value, HValue* context, HValue* parameter_count) { 1437 HReturn(HValue* value, HValue* context, HValue* parameter_count) {
1439 SetOperandAt(0, value); 1438 SetOperandAt(0, value);
1440 SetOperandAt(1, context); 1439 SetOperandAt(1, context);
1441 SetOperandAt(2, parameter_count); 1440 SetOperandAt(2, parameter_count);
1442 } 1441 }
1443 }; 1442 };
1444 1443
1445 1444
1446 class HAbnormalExit V8_FINAL : public HTemplateControlInstruction<0, 0> {
1447 public:
1448 virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE {
1449 return Representation::None();
1450 }
1451
1452 DECLARE_CONCRETE_INSTRUCTION(AbnormalExit)
1453 };
1454
1455
1456 class HUnaryOperation : public HTemplateInstruction<1> { 1445 class HUnaryOperation : public HTemplateInstruction<1> {
1457 public: 1446 public:
1458 HUnaryOperation(HValue* value, HType type = HType::Tagged()) 1447 HUnaryOperation(HValue* value, HType type = HType::Tagged())
1459 : HTemplateInstruction<1>(type) { 1448 : HTemplateInstruction<1>(type) {
1460 SetOperandAt(0, value); 1449 SetOperandAt(0, value);
1461 } 1450 }
1462 1451
1463 static HUnaryOperation* cast(HValue* value) { 1452 static HUnaryOperation* cast(HValue* value) {
1464 return reinterpret_cast<HUnaryOperation*>(value); 1453 return reinterpret_cast<HUnaryOperation*>(value);
1465 } 1454 }
(...skipping 5473 matching lines...) Expand 10 before | Expand all | Expand 10 after
6939 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 6928 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
6940 }; 6929 };
6941 6930
6942 6931
6943 #undef DECLARE_INSTRUCTION 6932 #undef DECLARE_INSTRUCTION
6944 #undef DECLARE_CONCRETE_INSTRUCTION 6933 #undef DECLARE_CONCRETE_INSTRUCTION
6945 6934
6946 } } // namespace v8::internal 6935 } } // namespace v8::internal
6947 6936
6948 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6937 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/hydrogen-environment-liveness.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698