Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Replaced ASSERTs with DCHECKS in presubmit warnings Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
index 8fe0041f093d33471cfabf899454db4576cb7a4f..072bcf87e6a3d0b3b8b7cb734aa2c98fb1b5eb93 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
@@ -33,6 +33,7 @@
#include "core/CSSValueKeywords.h"
#include "core/HTMLNames.h"
#include "core/clipboard/Pasteboard.h"
+#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSValueList.h"
#include "core/css/StylePropertySet.h"
#include "core/dom/DocumentFragment.h"
@@ -1246,7 +1247,7 @@ static bool executeSetMark(LocalFrame& frame, Event*, EditorCommandSource, const
static bool executeStrikethrough(LocalFrame& frame, Event*, EditorCommandSource source, const String&)
{
- CSSPrimitiveValue* lineThrough = CSSPrimitiveValue::createIdentifier(CSSValueLineThrough);
+ CSSIdentifierValue* lineThrough = CSSIdentifierValue::createIdentifier(CSSValueLineThrough);
return executeToggleStyleInList(frame, source, InputEvent::InputType::StrikeThrough, CSSPropertyWebkitTextDecorationsInEffect, lineThrough);
}
@@ -1301,7 +1302,7 @@ static bool executeTranspose(LocalFrame& frame, Event*, EditorCommandSource, con
static bool executeUnderline(LocalFrame& frame, Event*, EditorCommandSource source, const String&)
{
- CSSPrimitiveValue* underline = CSSPrimitiveValue::createIdentifier(CSSValueUnderline);
+ CSSIdentifierValue* underline = CSSIdentifierValue::createIdentifier(CSSValueUnderline);
return executeToggleStyleInList(frame, source, InputEvent::InputType::Underline, CSSPropertyWebkitTextDecorationsInEffect, underline);
}

Powered by Google App Engine
This is Rietveld 408576698