third_party/WebKit/Source/core/dom/Element.cpp - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Replaced ASSERTs with DCHECKS in presubmit warnings Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp ('K') | « third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp ('k') | third_party/WebKit/Source/core/dom/TextLinkColors.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index c3a1e143cca4358eb8619f5b7f574d4ce9154ec1..2a7f157437a82a512d382f5317ea3944131a0097 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -38,6 +38,7 @@

#include "core/animation/AnimationTimeline.h"

#include "core/animation/CustomCompositorAnimations.h"

#include "core/animation/css/CSSAnimations.h"

+#include "core/css/CSSIdentifierValue.h"

#include "core/css/CSSImageValue.h"

#include "core/css/CSSPrimitiveValue.h"

#include "core/css/CSSStyleSheet.h"

@@ -3651,7 +3652,7 @@ void Element::inlineStyleChanged()

void Element::setInlineStyleProperty(CSSPropertyID propertyID, CSSValueID identifier, bool important)

{

- setInlineStyleProperty(propertyID, CSSPrimitiveValue::createIdentifier(identifier), important);

+ setInlineStyleProperty(propertyID, CSSIdentifierValue::createIdentifier(identifier), important);

}

void Element::setInlineStyleProperty(CSSPropertyID propertyID, double value, CSSPrimitiveValue::UnitType unit, bool important)

@@ -3707,7 +3708,7 @@ void Element::updatePresentationAttributeStyle()

void Element::addPropertyToPresentationAttributeStyle(MutableStylePropertySet* style, CSSPropertyID propertyID, CSSValueID identifier)

{

DCHECK(isStyledElement());

- style->setProperty(propertyID, *CSSPrimitiveValue::createIdentifier(identifier));

+ style->setProperty(propertyID, *CSSIdentifierValue::createIdentifier(identifier));

}

void Element::addPropertyToPresentationAttributeStyle(MutableStylePropertySet* style, CSSPropertyID propertyID, double value, CSSPrimitiveValue::UnitType unit)