Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Replaced ASSERTs with DCHECKS in presubmit warnings Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
index 7b407571adc569784e1ec51023e4e98ec7a376b8..60f4103fef92c2650c2fa6f0d9024ec420db3b1b 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
@@ -7,6 +7,7 @@
#include "core/StylePropertyShorthand.h"
#include "core/css/CSSColorValue.h"
#include "core/css/CSSFunctionValue.h"
+#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSInheritedValue.h"
#include "core/css/CSSInitialValue.h"
#include "core/css/CSSPrimitiveValue.h"
@@ -451,7 +452,7 @@ CSSValue* CSSParserFastPaths::parseColor(const String& string, CSSParserMode par
if (StyleColor::isColorKeyword(valueID)) {
if (!isValueAllowedInMode(valueID, parserMode))
return nullptr;
- return CSSPrimitiveValue::createIdentifier(valueID);
+ return CSSIdentifierValue::createIdentifier(valueID);
}
RGBA32 color;
@@ -868,7 +869,7 @@ static CSSValue* parseKeywordValue(CSSPropertyID propertyId, const String& strin
if (valueID == CSSValueInitial)
return CSSInitialValue::create();
if (CSSParserFastPaths::isValidKeywordPropertyAndValue(propertyId, valueID, parserMode))
- return CSSPrimitiveValue::createIdentifier(valueID);
+ return CSSIdentifierValue::createIdentifier(valueID);
return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698