Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: third_party/WebKit/Source/core/css/CSSGradientValue.h

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Replaced ASSERTs with DCHECKS in presubmit warnings Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSGradientValue.h
diff --git a/third_party/WebKit/Source/core/css/CSSGradientValue.h b/third_party/WebKit/Source/core/css/CSSGradientValue.h
index 5163be895bfee02face31e6386ab973611ffcdc0..1e0cb07137726afeec3a778c1f0192f57924663e 100644
--- a/third_party/WebKit/Source/core/css/CSSGradientValue.h
+++ b/third_party/WebKit/Source/core/css/CSSGradientValue.h
@@ -26,6 +26,7 @@
#ifndef CSSGradientValue_h
#define CSSGradientValue_h
+#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSImageGeneratorValue.h"
#include "core/css/CSSPrimitiveValue.h"
#include "wtf/RefPtr.h"
@@ -190,8 +191,8 @@ public:
void setFirstRadius(CSSPrimitiveValue* val) { m_firstRadius = val; }
void setSecondRadius(CSSPrimitiveValue* val) { m_secondRadius = val; }
- void setShape(CSSPrimitiveValue* val) { m_shape = val; }
- void setSizingBehavior(CSSPrimitiveValue* val) { m_sizingBehavior = val; }
+ void setShape(CSSIdentifierValue* val) { m_shape = val; }
+ void setSizingBehavior(CSSIdentifierValue* val) { m_sizingBehavior = val; }
void setEndHorizontalSize(CSSPrimitiveValue* val) { m_endHorizontalSize = val; }
void setEndVerticalSize(CSSPrimitiveValue* val) { m_endVerticalSize = val; }
@@ -217,8 +218,8 @@ private:
Member<CSSPrimitiveValue> m_secondRadius;
// The below are only used for non-deprecated gradients. Any of them may be null.
- Member<CSSPrimitiveValue> m_shape;
- Member<CSSPrimitiveValue> m_sizingBehavior;
+ Member<CSSIdentifierValue> m_shape;
+ Member<CSSIdentifierValue> m_sizingBehavior;
Member<CSSPrimitiveValue> m_endHorizontalSize;
Member<CSSPrimitiveValue> m_endVerticalSize;

Powered by Google App Engine
This is Rietveld 408576698