third_party/WebKit/Source/core/animation/animatable/AnimatableUnknownTest.cpp - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableUnknownTest.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Replaced ASSERTs with DCHECKS in presubmit warnings Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h ('k') | third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp » ('j') | third_party/WebKit/Source/core/css/CSSIdentifierValue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/animatable/AnimatableUnknownTest.cpp

diff --git a/third_party/WebKit/Source/core/animation/animatable/AnimatableUnknownTest.cpp b/third_party/WebKit/Source/core/animation/animatable/AnimatableUnknownTest.cpp

index 7fa9cc6e1256417c0a6d5ed3f7da9a5ddf25d140..c990f54248e0363fc0723f2c26912d02af598ab4 100644

--- a/third_party/WebKit/Source/core/animation/animatable/AnimatableUnknownTest.cpp

+++ b/third_party/WebKit/Source/core/animation/animatable/AnimatableUnknownTest.cpp

@@ -40,10 +40,10 @@ class AnimationAnimatableUnknownTest : public ::testing::Test {

protected:

virtual void SetUp()

{

- cssValue = CSSPrimitiveValue::createIdentifier(CSSValueYellow);

+ cssValue = CSSIdentifierValue::createIdentifier(CSSValueYellow);

animatableUnknown = AnimatableUnknown::create(cssValue);

- otherCSSValue = CSSPrimitiveValue::createIdentifier(CSSValueOrange);

+ otherCSSValue = CSSIdentifierValue::createIdentifier(CSSValueOrange);

otherAnimatableUnknown = AnimatableUnknown::create(otherCSSValue);

}