Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Rebase please work Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
index a71f215bdbac2fa949f1ac7ba0206c05a1690c8b..c0ec07bb9f9b62c4d65ff31ce79efdc5a9bb2f67 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
@@ -45,6 +45,7 @@
#include "core/css/CSSCustomIdentValue.h"
#include "core/css/CSSDefaultStyleSheets.h"
#include "core/css/CSSFontSelector.h"
+#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSKeyframeRule.h"
#include "core/css/CSSKeyframesRule.h"
#include "core/css/CSSReflectValue.h"
@@ -799,7 +800,7 @@ PassRefPtr<ComputedStyle> StyleResolver::styleForElement(Element* element, const
MatchedPropertiesRange properties = collector.matchedResult().authorRules();
for (auto it = properties.begin(); it != properties.end(); ++it) {
const CSSValue* value = it->properties->getPropertyCSSValue(CSSPropertyDisplay);
- if (value && value->isPrimitiveValue() && toCSSPrimitiveValue(*value).getValueID() == CSSValueBlock)
+ if (value && value->isIdentifierValue() && toCSSIdentifierValue(*value).getValueID() == CSSValueBlock)
UseCounter::count(element->document(), UseCounter::SummaryElementWithDisplayBlockAuthorRule);
}
}

Powered by Google App Engine
This is Rietveld 408576698