Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Rebase please work Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp
index cc302d204de2034a66c041f2a7c5a53d92b720db..8c9b8ee73543688a78cfcade553d6da2490a64aa 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp
@@ -4,7 +4,7 @@
#include "core/css/parser/CSSParserFastPaths.h"
-#include "core/css/CSSPrimitiveValue.h"
+#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSValueList.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -14,10 +14,9 @@ TEST(CSSParserFastPathsTest, ParseKeyword)
{
CSSValue* value = CSSParserFastPaths::maybeParseValue(CSSPropertyFloat, "left", HTMLStandardMode);
ASSERT_NE(nullptr, value);
- EXPECT_TRUE(value->isPrimitiveValue());
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- EXPECT_TRUE(primitiveValue->isValueID());
- EXPECT_EQ(CSSValueLeft, primitiveValue->getValueID());
+ EXPECT_TRUE(value->isIdentifierValue());
+ CSSIdentifierValue* identifierValue = toCSSIdentifierValue(value);
+ EXPECT_EQ(CSSValueLeft, identifierValue->getValueID());
value = CSSParserFastPaths::maybeParseValue(CSSPropertyFloat, "foo", HTMLStandardMode);
ASSERT_EQ(nullptr, value);
}

Powered by Google App Engine
This is Rietveld 408576698