third_party/WebKit/Source/core/css/MediaQueryExp.cpp - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/MediaQueryExp.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Rebase please work Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/MediaQueryExp.cpp

diff --git a/third_party/WebKit/Source/core/css/MediaQueryExp.cpp b/third_party/WebKit/Source/core/css/MediaQueryExp.cpp

index 446f9fc81689f44fdc74960af8fd0ade20c4884d..b4234534fe4194013e66fc7d5ed74f19e262a0b1 100644

--- a/third_party/WebKit/Source/core/css/MediaQueryExp.cpp

+++ b/third_party/WebKit/Source/core/css/MediaQueryExp.cpp

@@ -221,7 +221,6 @@ MediaQueryExp* MediaQueryExp::createIfValid(const String& mediaFeature, const Ve

if (!featureWithValidIdent(lowerMediaFeature, ident))

return nullptr;

expValue.id = ident;

- expValue.unit = CSSPrimitiveValue::UnitType::ValueID;

expValue.isID = true;

} else if (token.type() == NumberToken || token.type() == PercentageToken || token.type() == DimensionToken) {

// Check for numeric token types since it is only safe for these types to call numericValue.